Modify
Warning Please read the Ticket HowTo before creating or commenting on a ticket. Failure to do so may cause your ticket to be rejected or result in a slower response.

Opened 3 years ago

Closed 19 months ago

#9395 closed Patch - Feature (fixed)

New system events: watch rec, watch video, listen to music

Reported by: Dave Badia <dbadia@…> Owned by: stuartm
Priority: minor Milestone: 0.27
Component: MythTV - General Version: Master Head
Severity: low Keywords:
Cc: Ticket locked: no

Description

Trigger system events when entering the watch recordings screen, the watch videos screen, and the play music screen.

My use case is that I control my receiver via rs232 and had different audio settings for tv, movies, and music. The rs232 scripts take 4-5 seconds to execute hence the "early" trigger when selecting watch recordings (as opposed to when a recording is selected) and watch videos

Depends on #9394

Attachments (3)

newevent.diff (2.7 KB) - added by Dave Badia <dbadia@…> 3 years ago.
newevent2.diff (2.7 KB) - added by David Badia <dbadia@…> 3 years ago.
screen-event.diff (1.8 KB) - added by Dave Badia <dbadia@…> 2 years ago.
Changes outline by Chris to re-enable this

Download all attachments as: .zip

Change History (12)

Changed 3 years ago by Dave Badia <dbadia@…>

comment:1 Changed 3 years ago by cpinkham

  • Owner changed from beirdo to cpinkham
  • Status changed from new to assigned

Changed 3 years ago by David Badia <dbadia@…>

comment:2 Changed 3 years ago by David Badia <dbadia@…>

newevent2.diff to fix typo in menu

comment:3 Changed 3 years ago by wagnerrp

  • Component changed from MythTV - MythSystem to MythTV - General

comment:4 Changed 3 years ago by Github

  • Milestone changed from unknown to 0.25
  • Resolution set to fixed
  • Status changed from assigned to closed

Add a new EventCmdScreenType? MythSystemEvent?.

Add a new System Event that is sent out whenever a new screen is
created or an existing screen is destroyed. This will allow users
to take external actions whenever an application enters or leaves
a screen/dialog.

The system event is SCREEN_TYPE and the setting name is
EventCmdScreenType?. The first argument in the %ARGS% value is
either 'CREATED' or 'DESTROYED' depending on whether a MythScreenType?
was created or destroyed.

Fixes #9395.

Branch: master
Changeset: 87b89dee6c8c6a4ffd89ca5857de4a4e791fcd82

comment:5 Changed 2 years ago by cpinkham

  • Milestone changed from 0.25 to 0.26
  • Resolution fixed deleted
  • Severity changed from medium to low
  • Status changed from closed to new
  • Version changed from Unspecified to Master Head

This commit was reverted in changeset b603bf39.

If you compile from source, and want to test a fix, you can uncomment those lines yourself. To
fix the issue that caused the revert commit, you should be able to uncomment
and add the following before each of the SendSystemEvent? lines that are
commented out.

if (QCoreApplication::applicationName() == MYTH_APPNAME_MYTHFRONTEND)

Once we cut 0.25, we should be able to get this code re-enabled in git master.

comment:6 Changed 2 years ago by Dave Badia <dbadia@…>

Thanks for the info on this, it all makes sense. I went ahead and made the changes you outlined. Tested it here and it all works well, including being able to run mythtv-setup. I'll attach a diff of the change against master in case it's helpful for the future work.

Changed 2 years ago by Dave Badia <dbadia@…>

Changes outline by Chris to re-enable this

comment:7 Changed 19 months ago by kenni

  • Milestone changed from 0.26 to 0.27

comment:8 Changed 19 months ago by stuartm

  • Owner changed from cpinkham to stuartm
  • Status changed from new to accepted

comment:9 Changed 19 months ago by Dave Badia <dbadia@…>

  • Resolution set to fixed
  • Status changed from accepted to closed

In 915edac92677f07c653de6e4ffe19e8ceac2d47b/mythtv:

Trigger system events for each screen

Closes #9395

Signed-off-by: Stuart Morgan <smorgan@…>

Add Comment

Modify Ticket

Action
as closed .
The resolution will be deleted. Next status will be 'new'.
Author


E-mail address and user name can be saved in the Preferences.

 
Note: See TracTickets for help on using tickets.