Opened 9 years ago

Closed 8 years ago

#9455 closed Bug Report - General (Fixed)

Mythweb drops thumbnails after manual edit

Reported by: jlatz@… Owned by: stuartm
Priority: minor Milestone: 0.25
Component: Plugin - MythWeb Version: 0.24-fixes
Severity: low Keywords: Mythweb, thumbnail, edit
Cc: Ticket locked: no

Description

When I attempt a manual edit of video information via the Mythweb interface, the result is that the thumbnail gets dropped.

I seem to have tracked it down to the fact that the mythweb/classes/Video.php script incorrectly copies the file/path name back into the database. I first made the fix in 0.23-fixes, and the fix seems to still work with 0.24-fixes (I just upgraded yesterday, and hacked in the fixes today).

I've edited the script such that it works for me, and am attaching it for your review. I've commented out the original code and inserted my own - a simple diff command to released source should identify the changes.

But, in case I can't successfully upload my file: line 79:80

$this->cover_file = path; list($width, $height) = @getimagesize($this->cover_file);

$this->cover_path = $path; list($width, $height) = @getimagesize($this->cover_path);

line 115:

.(($_SESSIONshow_video_covers? && file_exists($this->cover_url)) ? ' src="data/video_covers/'.basename($this->cover_file).'"' : )

.(($_SESSIONshow_video_covers? && file_exists($this->cover_path)) ? ' src="data/video_covers/'.basename($this->cover_file).'"' : )

line 169:

( @filesize($this->cover_file) > 0 ? $this->cover_file : 'No Cover' ),

( @filesize($this->cover_path) > 0 ? $this->cover_file : 'No Cover' ),

Attachments (2)

Video.php (7.9 KB) - added by jlatz@… 9 years ago.
hacked version of mythtv/mythweb/classes/Video.php
Video.php.diff (1.8 KB) - added by jlatz@… 9 years ago.

Download all attachments as: .zip

Change History (5)

Changed 9 years ago by jlatz@…

Attachment: Video.php added

hacked version of mythtv/mythweb/classes/Video.php

comment:1 Changed 9 years ago by Kenni Lund [kenni a kelu dot dk]

Status: newassigned
Version: Unspecified0.24-fixes

jlatz, a unified diff (diff -u) of your changes is preferred...thanks

Changed 9 years ago by jlatz@…

Attachment: Video.php.diff added

comment:2 Changed 8 years ago by stuartm

Milestone: unknown0.25
Owner: changed from Rob Smith to stuartm
Status: assignedaccepted
Type: Bug ReportBug Report - General

comment:3 Changed 8 years ago by stuartm

Resolution: Fixed
Status: acceptedclosed

Looks like this has already been fixed

Note: See TracTickets for help on using tickets.