Opened 13 years ago

Closed 13 years ago

Last modified 13 years ago

#9549 closed Bug Report (fixed)

Myth Transcode Runs Forever

Reported by: Scott Harris <snharris99@…> Owned by: beirdo
Priority: minor Milestone: 0.24.1
Component: MythTV - Mythtranscode Version: Unspecified
Severity: medium Keywords:
Cc: Ticket locked: no

Description

I only do lossless transcodes to remove commercials. for the last few months, transcodes of programs off of one channel only have started to never complete. The always get stuck in the 30% - 35% range and will run forever until I manually "killall mythtranscode".

The backend log is ultimately huge (like 200MB this morning from a job started last night that ran for 9 hours before manually stopped), full of (written more than once per second)

2011-02-05 08:53:55.414 Failed to decode frame. Position was: 0 2011-02-05 08:53:55.422 Couldn't open file abort.dat

As indicated it is only programs off of one Fox channel in my area that this occurs with.

Attachments (2)

version_info (673 bytes) - added by Raymond Wagner 13 years ago.
attaching as a file, as the text says to
0001-Make-MPEG2fixup-ProcessVideo-return-int.patch (1.9 KB) - added by beirdo 13 years ago.

Download all attachments as: .zip

Change History (17)

comment:1 Changed 13 years ago by beirdo

Status: newinfoneeded_new

Please attach the output of "mythfrontend --version" so we know what version you are using.

comment:2 Changed 13 years ago by beirdo

Owner: set to beirdo

comment:3 Changed 13 years ago by Scott Harris <snharris99@…>

moved to attachment

Last edited 13 years ago by Raymond Wagner (previous) (diff)

Changed 13 years ago by Raymond Wagner

Attachment: version_info added

attaching as a file, as the text says to

Changed 13 years ago by beirdo

comment:4 Changed 13 years ago by beirdo

please try the attached patch, and try one of those bad recordings again.

comment:5 Changed 13 years ago by Scott Harris <snharris99@…>

If someone could point me to how to apply a patch, I'll be happy to try. I don't compile my own, I just install MythBuntu?, and use daily builds. I just had another one to test with from last night.

comment:6 Changed 13 years ago by beirdo

Committed to master in 0234965c20b1. Let me know if it fixes the bad recordings issue.

comment:7 Changed 13 years ago by Scott Harris <snharris99@…>

At the risk of sounding like a simpleton, with the new version numbers, how does one tell anymore? I just updated this morning, and I am now showing

mythtv-transcode-utils 2:0.24.0+fixes.20110224.e0a7720-0ubuntu0mythbuntu1

How do I know when I now contain that commit?

comment:8 Changed 13 years ago by Kenni Lund [kenni a kelu dot dk]

Scott, beirdo comitted the change to master (=0.25pre), you'll not receive this change when you run 0.24-fixes.

You can either:

  1. Upgrade to master through Mythbuntu autobuilds (you'll need to manually backup and restore your DB, if you want to revert to 0.24-fixes after testing the fix).
  2. Compile 0.24-fixes with the patch. I suggested how you could do this without affecting your current setup, in http://www.gossamer-threads.com/lists/mythtv/dev/472502

comment:9 Changed 13 years ago by Gavin Hurlbut

Resolution: fixed
Status: infoneeded_newclosed

Make MPEG2fixup::ProcessVideo? return int

I'm not 100% sure what the original author was trying to do here, but this code is broken. Returning 0, 1, -1 for a bool makes no sense, and comparing bool < 0 makes even less sense. Rather than trying to unravel what he was trying to do, let's make this a simple int return so the return codes should have some effect.

Fixes #9549

Changeset: 0234965c20b1d0fd8243ed395e3e6229e790d672

comment:10 Changed 13 years ago by Scott Harris <snharris99@…>

I just want to say that with kenni's help I was finally able to apply your patch. I tested on one of my recordings and while it still would transcode, it did at least gracefully fail and not just keep running forever.

I'd call that a win.

comment:11 Changed 13 years ago by beirdo

Milestone: unknown0.25

comment:12 Changed 13 years ago by Scott Harris <snharris99@…>

Is there any chance this can be back ported?

comment:13 Changed 13 years ago by Gavin Hurlbut

Make MPEG2fixup::ProcessVideo? return int

I'm not 100% sure what the original author was trying to do here, but this code is broken. Returning 0, 1, -1 for a bool makes no sense, and comparing bool < 0 makes even less sense. Rather than trying to unravel what he was trying to do, let's make this a simple int return so the return codes should have some effect.

Fixes #9549 (cherry picked from commit 0234965c20b1d0fd8243ed395e3e6229e790d672)

Changeset: bbfb6b02ab10c1fe1da1711415ac82a1e4642486

comment:14 Changed 13 years ago by beirdo

Done. Sorry, I meant to do that earlier.

comment:15 Changed 13 years ago by beirdo

Milestone: 0.250.24.1
Note: See TracTickets for help on using tickets.