Opened 9 years ago

Closed 8 years ago

#9581 closed Bug Report - Crash (Won't Fix)

[CRASH] mythcommflag SIGSEGV in ClassicLogoDetector::DetectEdges()

Reported by: Marc Randolph <mrand@…> Owned by: cpinkham
Priority: major Milestone: 0.25
Component: MythTV - Mythcommflag Version: 0.24-fixes
Severity: medium Keywords:
Cc: Ticket locked: no

Description

Crash while trying to commflag a (very) corrupt capture. I can upload the stream somewhere if it is desired - otherwise feel free to close this ticket if it is not worth pursuing.

Attachments (2)

ThreadStacktrace.txt (35.8 KB) - added by Marc Randolph <mrand@…> 9 years ago.
mythbackend.log.gz (166.1 KB) - added by Marc Randolph <mrand@…> 9 years ago.

Download all attachments as: .zip

Change History (12)

Changed 9 years ago by Marc Randolph <mrand@…>

Attachment: ThreadStacktrace.txt added

Changed 9 years ago by Marc Randolph <mrand@…>

Attachment: mythbackend.log.gz added

comment:1 Changed 9 years ago by beirdo

Summary: mythcommflag SIGSEGV in ClassicLogoDetector::DetectEdges()[CRASH] mythcommflag SIGSEGV in ClassicLogoDetector::DetectEdges()

comment:2 Changed 8 years ago by beirdo

Status: newinfoneeded_new

Is this repeatable? I am thinking of putting in some more null protection, but without a way to test it, I'm not sure if it's worth the effort.

comment:3 Changed 8 years ago by Marc Randolph <mrand@…>

It's been four months, but you are lucky - I did manage to find the recording. mythcommflag -v filename still crashes 0.24.1, if that is your question. I can upload the recording somewhere if that is desired.

comment:4 Changed 8 years ago by beirdo

Sure, if you could. This would help test the extra protection that I'm thinking of putting in. Few of my files get bad enough to still crash commflagging.

comment:5 Changed 8 years ago by Marc Randolph <mrand@…>

Here is a small sample: http://www.2shared.com/video/4varxuGf/cut.html I'll try to remember to upload a larger one overnight

comment:6 Changed 8 years ago by beirdo

See also #10089

comment:7 Changed 8 years ago by cpinkham

If this is still happening, is there any chance you can upload the sample file again? Fixing checks for the null buf pointer won't help solve the underlying problem that we are getting a null pointer from the decoder. We should fix this in the decoder rather than at every point where we touch the buf pointer.

comment:8 Changed 8 years ago by stuartm

Priority: minormajor
Type: Bug ReportBug Report - Crash

comment:9 Changed 8 years ago by stuartm

Milestone: unknown0.25

comment:10 Changed 8 years ago by beirdo

Resolution: Won't Fix
Status: infoneeded_newclosed

The file in question was not even watchable. In cases like these, while it would be nice to not crash, it's something inside ffmpeg code that is actually crashing, so without extensive debugging inside their code, it's best to assume this will not get fixed. If your recording is that screwed, delete it and re-record, and live with commflagging crashing on it.

Note: See TracTickets for help on using tickets.