Modify

Opened 4 years ago

Closed 12 months ago

Last modified 12 months ago

#9589 closed Patch - Bug Fix (fixed)

[PATCH] libmythui: fullscreen doesn't cover gnome panel with compiz

Reported by: Lawrence Rust <lvr@…> Owned by: Jean-Yves Avenard <jyavenard@…>
Priority: minor Milestone: 0.27.1
Component: MythTV - User Interface Library Version: 0.24-fixes
Severity: medium Keywords: fullscreen gnome panel
Cc: Ticket locked: no

Description

It's been a bit of an annoyance for me and the source of several past bug reports that when mythfrontend is run fullscreen on a Gnome desktop using Compiz effects then the upper and lower panels are not covered, unless auto-hiding is enabled.

The problem can be overcome by installing CompizConfig? settings and enabling "Legacy Fullscreen Support" in workarounds - implying that this is a MythTV bug. However, on investigation it appears that it's actually a Compiz bug that's easily worked around by making the window visible before setting the fullscreen state. The attached one-line patch does this.

Attachments (1)

31-fullscreen.diff (576 bytes) - added by Lawrence Rust <lvr@…> 4 years ago.

Download all attachments as: .zip

Change History (17)

Changed 4 years ago by Lawrence Rust <lvr@…>

comment:1 Changed 4 years ago by markk

  • Milestone changed from unknown to 0.24.1
  • Owner set to markk
  • Status changed from new to accepted
  • Version changed from Unspecified to 0.24-fixes

Slightly different approach applied to master in 3ad6c81aa83491b7e6d2.

If there are no reported side-effects, I'll backport to fixes in a few days.

comment:2 Changed 4 years ago by Stuart Morgan

  • Resolution set to fixed
  • Status changed from accepted to closed

Fix mouse usage in popups, thanks to Paul for spotting the error. Fixes #9589

Changeset: afb8995fe52dd3a3f35ab6c256fd556cce68fd68

comment:3 Changed 4 years ago by paulh

  • Resolution fixed deleted
  • Status changed from closed to new

comment:4 Changed 4 years ago by markk

Fix for mutli-screen setups applied in 4322464f6bd4f5a2c26a

comment:5 Changed 4 years ago by markk

  • Resolution set to Fixed
  • Status changed from new to closed

Applied to fixes/0.24 in 8cc2e9aa27220248d8b1

comment:6 Changed 4 years ago by Mark Kendall

libmythui: Revert recent Compiz/fullscreen window fixes.

Some multi-screen setups (TwinView?) are still broken despite an attempted fix. I can't honestly see any combination of initialisation sequence that fixes both the Compiz issue and doesn't break Twinview setups, so reverting until someone can figure out a better way.

Refs #9589

Changeset: 003fc8fb14acc9a6c4aeea2001d33d4cdb3c253d

comment:7 Changed 4 years ago by Mark Kendall

libmythui: Revert recent Compiz/fullscreen window fixes.

Some multi-screen setups (TwinView?) are still broken despite an attempted fix. I can't honestly see any combination of initialisation sequence that fixes both the Compiz issue and doesn't break Twinview setups, so reverting until someone can figure out a better way.

Refs #9589 (cherry picked from commit 003fc8fb14acc9a6c4aeea2001d33d4cdb3c253d)

Changeset: db3cfd3273016b741b68541ed322cc89e599a3a1

comment:8 Changed 4 years ago by markk

  • Resolution Fixed deleted
  • Status changed from closed to new

comment:9 Changed 4 years ago by markk

  • Component changed from MythTV - General to MythTV - User Interface Library
  • Owner markk deleted
  • Status changed from new to assigned

I have far too many tickets to deal with, so leaving this to someone who has the time and inclination.

comment:10 Changed 4 years ago by beirdo

  • Milestone changed from 0.24.1 to unknown

comment:11 Changed 3 years ago by beirdo

  • Resolution set to Won't Fix
  • Status changed from assigned to closed

comment:12 Changed 3 years ago by beirdo

This went through several unsuccessful iterations. Time to put it out of its misery.

comment:13 Changed 12 months ago by jyavenard

  • Resolution Won't Fix deleted
  • Status changed from closed to new

comment:14 Changed 12 months ago by Jean-Yves Avenard <jyavenard@…>

  • Owner set to Jean-Yves Avenard <jyavenard@…>
  • Resolution set to fixed
  • Status changed from new to closed

In 1c440ba970bfa0718bd5bc240f412e0bbc24ccf5/mythtv:

Fix fullscreen windowing with Compiz/Unity?

Also fixes live transitions from full screen to windowed screen.

Tested on the following systems:

  • Linux Ubuntu 12.04 and 14.04, with box Xfce and Unity, with multi and single screens setup (including TwinView?). AMD, nVidia and intel drivers.
  • MacOS 10.9: multi and single screens setup

Fixes #9589
Fixes #8021
Fixes #7958

comment:15 Changed 12 months ago by jyavenard

  • Milestone changed from unknown to 0.27.1

comment:16 Changed 12 months ago by Jean-Yves Avenard <jyavenard@…>

In 25876a76e4e064ba828d0b92c1bbaea218882c81/mythtv:

Fix fullscreen windowing with Compiz/Unity?

Also fixes live transitions from full screen to windowed screen.

Tested on the following systems:

  • Linux Ubuntu 12.04 and 14.04, with box Xfce and Unity, with multi and single screens setup (including TwinView?). AMD, nVidia and intel drivers.
  • MacOS 10.9: multi and single screens setup

Fixes #9589
Fixes #8021
Fixes #7958

(cherry picked from commit 1c440ba970bfa0718bd5bc240f412e0bbc24ccf5)

Add Comment

Modify Ticket

Action
as closed The owner will remain Jean-Yves Avenard <jyavenard@…>.
The resolution will be deleted. Next status will be 'new'.
Author


E-mail address and user name can be saved in the Preferences.

 
Note: See TracTickets for help on using tickets.