Opened 8 years ago

Last modified 11 months ago

#9597 accepted Patch - Feature

Add support for random artwork in mythui

Reported by: erictsmith@… Owned by: stuartm
Priority: minor Milestone: 29.2
Component: MythTV - User Interface Library Version: Master Head
Severity: medium Keywords:
Cc: Ticket locked: no

Description

This patch adds support for mythui images to be pulled randomly from the fanart, coverart, and banners directories as defined by the front end mythvideo settings. It does not currently support storage groups. To use, simply add an imagestate to your ui xml and add a filename using of the special tags: %FANART% %BANNERART% or %COVERART%

Patches for fixes/0.24 and master are attached. Only the fixes/0.24 patch is tested as I do not currently have a box running master.

Attachments (4)

randomfanart_fixes24.patch (1.5 KB) - added by erictsmith@… 8 years ago.
fixes/0.24 patch
randomfanart_master.patch (1.5 KB) - added by erictsmith@… 8 years ago.
master patch
randomsg_fixes24.patch (2.3 KB) - added by erictsmith@… 8 years ago.
fixes/0.24 patch with storage group support
randomsg_master.patch (2.3 KB) - added by erictsmith@… 8 years ago.
master patch with storage group support

Download all attachments as: .zip

Change History (16)

Changed 8 years ago by erictsmith@…

Attachment: randomfanart_fixes24.patch added

fixes/0.24 patch

Changed 8 years ago by erictsmith@…

Attachment: randomfanart_master.patch added

master patch

comment:1 Changed 8 years ago by robertm

Owner: changed from stuartm to robertm
Status: newassigned

Patch is not acceptable, needs to support storage groups, and variable names should be "BANNERS" rather than bannerart, and screenshots need to be supported.

If you would do the preceding we can think about this, but using the legacy local locations is probably a non-starter.

comment:2 Changed 8 years ago by robertm

Status: assignedinfoneeded

Changed 8 years ago by erictsmith@…

Attachment: randomsg_fixes24.patch added

fixes/0.24 patch with storage group support

Changed 8 years ago by erictsmith@…

Attachment: randomsg_master.patch added

master patch with storage group support

comment:3 Changed 8 years ago by erictsmith@…

Status: infoneededassigned

Updated patch adds support for mythui images to be pulled randomly from any storage group. To use, simply add an imagestate to your ui xml and add a filename using of the special tag: %SG_<storage group name>%. Likely storage groups would be the special metadata groups, but any could be used. Storage group code will fall back to the Default group if the specified group does not exist and make up to 10 attempts at finding a random image file in the given group.

Patches for fixes/0.24 and master are attached. Only the fixes/0.24 patch is tested as I do not currently have a box running master.

comment:4 Changed 7 years ago by Raymond Wagner

Version: UnspecifiedTrunk Head

comment:5 Changed 7 years ago by robertm

Owner: robertm deleted

comment:6 Changed 7 years ago by Raymond Wagner

Status: assignednew

comment:7 Changed 5 years ago by stuartm

Milestone: unknown0.28
Owner: set to stuartm
Status: newaccepted

comment:8 Changed 3 years ago by paulh

Milestone: 0.280.29

Bump to 0.29

comment:9 Changed 3 years ago by Stuart Auchterlonie

Milestone: 0.2929.0

Milestone renamed

comment:10 Changed 13 months ago by Stuart Auchterlonie

Milestone: 29.029.1

comment:11 Changed 11 months ago by Stuart Auchterlonie

Milestone: 29.10.28.2

Moving remaining open tickets to 0.28.2 milestone

comment:12 Changed 11 months ago by Stuart Auchterlonie

Milestone: 0.28.229.2

Moving remaining open tickets to 29.2 milestone

Note: See TracTickets for help on using tickets.