Modify
Warning Please read the Ticket HowTo before creating or commenting on a ticket. Failure to do so may cause your ticket to be rejected or result in a slower response.

Opened 3 years ago

Closed 3 years ago

#9608 closed Patch - Bug Fix (Fixed)

Myth will not build with CrystalHD libraries after 01/23/11

Reported by: tom@… Owned by: markk
Priority: minor Milestone: 0.24.1
Component: MythTV - Video Playback Version: Master Head
Severity: medium Keywords:
Cc: Ticket locked: no

Description

privatedecoder_crystalhd.cpp: In function 'QString bcmerr_to_string(BC_STATUS)':
privatedecoder_crystalhd.cpp:864: error: 'BC_STS_CLK_NOCHG' was not declared in this scope
make[2]: * [privatedecoder_crystalhd.o] Error 1
make[2]:
* Waiting for unfinished jobs....
tv_play.cpp: In member function 'void TV::ProcessNetworkControlCommand?(PlayerContext?*, const QString&)':

I'm using Jarod's git tree to build the kernel module and libraries for my BCM70015 CrystalHD card. After the commits made there on 01/23, Myth will not build without patching privatedecoder_crystalhd.cpp.

I've used this patch on master for a few weeks now without any obvious defects.

Attachments (1)

mythtv-crystalhd.patch (603 bytes) - added by anonymous 3 years ago.

Download all attachments as: .zip

Change History (6)

Changed 3 years ago by anonymous

comment:1 Changed 3 years ago by robertm

  • Owner set to markk
  • Status changed from new to assigned

Patch does fix compilation here. AFAICT we're not checking library version and I didn't spend any time finding out if the library is bumping versions as the API changes. I'll leave it up to Mark whether he wants to apply it and/or check the library API in configure.

comment:2 Changed 3 years ago by robertm

As a followup, yes, the version was bumped. We probably ought to check these defines in configure.

http://git.wilsonet.com/crystalhd.git/?a=commitdiff;h=368ce4d4799dd27830fc83ebc7a0a24ebf2dd5ec

comment:3 Changed 3 years ago by Mark Kendall

CrystalHD: Fix compilation with recent CrystalHD library versions.

Techically, we should probably start checking the version numbers but
practically, the only issue appears to be one error enumeration that we
can simply do without.

Refs #9608

Changeset: a640aaa613f2665d3642b163e92aac48c02c2b2a

comment:4 Changed 3 years ago by Mark Kendall

CrystalHD: Fix compilation with recent CrystalHD library versions.

Techically, we should probably start checking the version numbers but
practically, the only issue appears to be one error enumeration that we
can simply do without.

Refs #9608
(cherry picked from commit a640aaa613f2665d3642b163e92aac48c02c2b2a)

Changeset: 83bc1fa51a099be93d38dc7d2a51bd050decdb4d

comment:5 Changed 3 years ago by markk

  • Component changed from MythTV - General to MythTV - Video Playback
  • Milestone changed from unknown to 0.24.1
  • Resolution set to Fixed
  • Status changed from assigned to closed
  • Version changed from Unspecified to Trunk Head

Add Comment

Modify Ticket

Action
as closed .
The resolution will be deleted. Next status will be 'new'.
Author


E-mail address and user name can be saved in the Preferences.

 
Note: See TracTickets for help on using tickets.