Myth will not build with CrystalHD libraries after 01/23/11

[tom@…]

privatedecoder_crystalhd.cpp: In function 'QString bcmerr_to_string(BC_STATUS)': privatedecoder_crystalhd.cpp:864: error: 'BC_STS_CLK_NOCHG' was not declared in this scope make[2]: * [privatedecoder_crystalhd.o] Error 1 make[2]: * Waiting for unfinished jobs.... tv_play.cpp: In member function 'void TV::ProcessNetworkControlCommand?(PlayerContext?*, const QString&)':

I'm using Jarod's git tree to build the kernel module and libraries for my BCM70015 CrystalHD card. After the commits made there on 01/23, Myth will not build without patching privatedecoder_crystalhd.cpp.

I've used this patch on master for a few weeks now without any obvious defects.

[robertm]

Patch does fix compilation here. AFAICT we're not checking library version and I didn't spend any time finding out if the library is bumping versions as the API changes. I'll leave it up to Mark whether he wants to apply it and/or check the library API in configure.

[robertm]

As a followup, yes, the version was bumped. We probably ought to check these defines in configure.

​http://git.wilsonet.com/crystalhd.git/?a=commitdiff;h=368ce4d4799dd27830fc83ebc7a0a24ebf2dd5ec

[Mark Kendall]

CrystalHD: Fix compilation with recent CrystalHD library versions.

Techically, we should probably start checking the version numbers but practically, the only issue appears to be one error enumeration that we can simply do without.

Refs #9608

Changeset: a640aaa613f2665d3642b163e92aac48c02c2b2a

[Mark Kendall]

CrystalHD: Fix compilation with recent CrystalHD library versions.

Techically, we should probably start checking the version numbers but practically, the only issue appears to be one error enumeration that we can simply do without.

Refs #9608 (cherry picked from commit a640aaa613f2665d3642b163e92aac48c02c2b2a)

Changeset: 83bc1fa51a099be93d38dc7d2a51bd050decdb4d