Opened 8 years ago

Closed 5 years ago

Last modified 5 years ago

#9632 closed Patch - Bug Fix (Won't Fix)

XBOX 360 Media Sharing is broken.

Reported by: bernard.van.vlimmeren@… Owned by: stuartm
Priority: minor Milestone: unknown
Component: MythTV - UPnP Version: Master Head
Severity: medium Keywords:
Cc: Ticket locked: no

Description

I recently (today) upgraded my mythtv version to the most recent code (including patches up till today). Unfortunately the upnp server does not return the correct data for the XBOX 360 anymore. As far as I can determine an xbox compatible upnp server needs to comply with: http://msdn.microsoft.com/en-us/windows/hardware/gg487545 However, when browsing videos (requesting containerId=15) from the xbox the server returns a list of object.item.videoitem while the xbox expects object.storagefolder. This causes the displayed list of videos to be empty.

In addition, when searching for music, the xbox requests containerId=7 which returns for some reason all recordings.

Attachments (5)

mythtvversion.txt (761 bytes) - added by bernard.van.vlimmeren@… 8 years ago.
Version
xbo360upnp (13.4 KB) - added by Joe Bryant <tenminjoe@…> 8 years ago.
Patch to make UPnP compatible with Xbox 360
upnpcdsmusicalbum.h (1.9 KB) - added by Joe Bryant <tenminjoe@…> 8 years ago.
upnpcdsmusicalbum.cpp (3.7 KB) - added by Joe Bryant <tenminjoe@…> 8 years ago.
xbox360upnp.diff (13.7 KB) - added by Joe Bryant <tenminjoe@…> 8 years ago.
Revised diff, this time against latest git source

Download all attachments as: .zip

Change History (20)

Changed 8 years ago by bernard.van.vlimmeren@…

Attachment: mythtvversion.txt added

Version

comment:1 Changed 8 years ago by Raymond Wagner

Priority: majorminor

Resetting this back to default priority.

Changed 8 years ago by Joe Bryant <tenminjoe@…>

Attachment: xbo360upnp added

Patch to make UPnP compatible with Xbox 360

Changed 8 years ago by Joe Bryant <tenminjoe@…>

Attachment: upnpcdsmusicalbum.h added

Changed 8 years ago by Joe Bryant <tenminjoe@…>

Attachment: upnpcdsmusicalbum.cpp added

comment:2 Changed 8 years ago by Joe Bryant <tenminjoe@…>

I've started work on making MythTV's UPnP compatible with the Xbox 360 again.

In this patch: Viewing music "by album", viewing "all songs", playing individual songs. Only MP3s are supported - the Xbox 360 doesn't play OGG or FLAC. I haven't looked at the video support at all.

This is a testing-the-water patch as I have not worked on MythTV before. If this patch goes through okay then I intend to look at fixing up the UPnP support some more.

I hope that NON-Xbox 360 users who have UPnP devices can test against this patch to make sure it doesn't break UPnP for them.

comment:3 Changed 8 years ago by Joe Bryant <tenminjoe@…>

Just noticed my patch has my home directory paths in it, betraying my total lack of experience with svn. Will try regenerating the patch correctly tomorrow.

comment:4 Changed 8 years ago by Jonathan <jonathan@…>

Replying to Joe Bryant <tenminjoe@…>:

Just noticed my patch has my home directory paths in it, betraying my total lack of experience with svn. Will try regenerating the patch correctly tomorrow.

You patch seems to still have SVN revision numbers and is therefore quite out of date as the source has been moved from SVN to Git for a while now (about 8 months IIRC), see also: http://code.mythtv.org/trac

Perhaps you should first test the latest source from Git before diving in, it might save you chasing ghosts.

comment:5 Changed 8 years ago by Joe Bryant <tenminjoe@…>

Thanks for letting me know - I'll get the git code and see what needs to be done.

It's a bit of a shame that it was so easy for me to end up working with the wrong code as a neophyte MythTV developer. I started at http://www.mythtv.org/wiki/Development_guide, which sent me to http://www.mythtv.org/docs/mythtv-HOWTO-5.html#ss5.2, which told me to get the latest source using subversion. The subversion repository is still up and running, so I assumed I was doing it right. Still, this is no doubt a discussion for elsewhere.

Changed 8 years ago by Joe Bryant <tenminjoe@…>

Attachment: xbox360upnp.diff added

Revised diff, this time against latest git source

comment:6 Changed 8 years ago by Joe Bryant <tenminjoe@…>

I've now recreated the patch against the latest git source (no significant changes).

comment:7 in reply to:  6 Changed 7 years ago by yannick.moussette@…

Replying to Joe Bryant <tenminjoe@…>:

I've now recreated the patch against the latest git source (no significant changes).

Hi Joe, thanks for the hard work... Do you know if this ever made it to the official Mythtv tree? Using the new 0.25 and still having issues with Xbox 360...

Thanks!

Yannick

comment:8 Changed 7 years ago by Joe Bryant <tenminjoe@…>

I never heard anything back after I submitted it, so I assume that, alas, it has not been included.

comment:9 Changed 6 years ago by stuartm

Owner: changed from dblain to stuartm
Status: newaccepted
Type: Bug Report - GeneralPatch - Bug Fix

comment:10 Changed 6 years ago by stuartm

Milestone: unknown0.28

comment:11 Changed 5 years ago by Stuart Morgan <smorgan@…>

In d8c0ad9930dd157106f651617d1217f1d6cce234/mythtv:

UPnP: Add the fraction of a second component to the 'Duration' attribute for music.

This is a no-op, it's entirely optional in the spec and we don't store
music duration to this resolution. I'm making the change because it
future proofs the upnp code should we ever decide to store music
duration down to the millisecond.

Refs #9632

comment:12 Changed 5 years ago by Stuart Morgan <smorgan@…>

In 84705913ebfe904d6cb85a3b192b6eacfe6537e3/mythtv:

UPnP: Ensure resource URIs are properly encoded and formatted.

Also fixed a couple of bugs.

  1. The 'medium' size artwork was being defined

twice for video and recordings.

  1. The thumbnail for recordings was using PNG which is within the

spec, but DLNA requires JPG be offered at a minimum. Since no client
will support PNG but not JPG, we may as well only offer JPG for now.

Refs #9632
Fixes #12202

comment:13 Changed 5 years ago by stuartm

Milestone: 0.28unknown

To clarify matters, the XBox 360 does not support UPnP. It only supports streaming from Windows Media Centre using a hardcoded proprietary protocol based on a subsection of UPnP. It is not UPnP or DLNA compliant.

Given the XBox 360 has been replaced and the volume of hacks in our UPnP code just to support the XBox, I'm inclined to close this as "Won't Fix" so we can instead focus on improving support for true UPnP clients.

comment:14 Changed 5 years ago by stuartm

Resolution: Won't Fix
Status: acceptedclosed

comment:15 Changed 5 years ago by stuartm

Summary: UPnP on XBOX 360 is broken.XBOX 360 Media Sharing is broken.
Note: See TracTickets for help on using tickets.