[PATCH] Fix SEGV faults in mythfrontend during backend selection

[Lawrence Rust <lvr@…>]

This patch fixes several segv faults and logic problems with mythfrontend during backend configuration either after a fresh install or by specifying the -p option.

1 Can't select Manual dbase configuration with -p option
2 Can't Cancel
3 Segv after selecting Save on win32
4 Segv in ShowOkPopup? due to stale static data
5 Segv in MythScreenStack::PopScreen? due to null pointer

[stuartm]

Are these issues reproducible on other platforms? I can't reproduce any of them.

[Lawrence Rust <lvr@…>]

All apart from 1 are reproducible on both Linux & Windows. The exception is the seg fault when you select Save caused by a NULL m_XML in BackendSelection::Accept

1. Start "mythfrontend -p", select language, tab to Manual and click. If your setup conforms to defaults you'll go to the root menu. If you have anything unusual you'll get a dialog - Cannot login.
2. Start "mythfrontend -p", select language, tab to cancel and click, same result as 1.
3. Win32 only: Start "mythfrontend -p", select language, tab to Save and click - SEGV
4. Start "mythfrontend -p", select language, tab to cancel and click - Cannot login. Click cancel again - SEGV

[sphery]

Ref: f53cc94e8

[sphery]

Segfaults have been fixed in master (by the above-referenced changeset and potentially other additional changes). (Though I can't test the win32 segfault, those mentioned as #4 and #5 in original description are fixed.)

[beirdo]

All that is pending is:

Segv after selecting Save on win32

[stuartm]

Code has changed significantly since this ticket was opened, the one remaining issue on win32 may or may not be fixed, but we'd need an updated patch. I'd suggest a new ticket is created if the bug persists.