Modify
Warning Please read the Ticket HowTo before creating or commenting on a ticket. Failure to do so may cause your ticket to be rejected or result in a slower response.

Opened 3 years ago

Closed 3 years ago

#9655 closed Bug Report - General (fixed)

mythvideo fails and locks when playing filename that begins with "#"

Reported by: Ryan Patterson <ryan.goat@…> Owned by: robertm
Priority: minor Milestone: 0.25
Component: MythTV - General Version: 0.24-fixes
Severity: medium Keywords: filename
Cc: Ticket locked: no

Description

Trying to use mythvideo to play a file with the name "#1 Cheerleader Camp.mpg" results in mythfrontend locking up at the "please wait" notification. Changing the file name to "1# Cheerleader Camp.mpg" resolves the error. So the error is only triggered by the filename beginning with the "#" character.

Maybe other special characters also trigger this error. I have not tested.

I will attempt to attach the log output from mythfrontend. But this should be easy to reproduce.

My results are with Ubuntu 10.10 MythTV 0.24-fixes compiled by me from git with no extra patches. Mythvideo uses storage groups.

Attachments (2)

error.log (10.8 KB) - added by Ryan Patterson <ryan.goat@…> 3 years ago.
mythfrontend log showing the error playing file: #1 Cheerleader Camp.mpg
hasfragment_v1.diff (944 bytes) - added by greg 3 years ago.
Fix for # in a myth URL

Download all attachments as: .zip

Change History (7)

Changed 3 years ago by Ryan Patterson <ryan.goat@…>

mythfrontend log showing the error playing file: #1 Cheerleader Camp.mpg

comment:1 Changed 3 years ago by robertm

  • Component changed from Plugin - MythVideo to MythTV - General

Not a MythVideo? specific error, this will happen with any URL with a # at the beginning in any part of Myth as it breaks URL parsing.

comment:2 Changed 3 years ago by robertm

  • Type changed from Bug Report - Crash to Bug Report - General

Also, this is not a crash.

Changed 3 years ago by greg

Fix for # in a myth URL

comment:3 follow-up: Changed 3 years ago by greg

Ryan: Please try the attached patch hasfragment_v1.diff

comment:4 in reply to: ↑ 3 Changed 3 years ago by Ryan Patterson <ryan.goat@…>

Replying to greg:

Ryan: Please try the attached patch hasfragment_v1.diff

I applied the patch to 0.24-fixes, recompiled and changed the filename back to the one myth had the problem with. The video now plays without issue. Thanks.

comment:5 Changed 3 years ago by Github

  • Milestone changed from unknown to 0.25
  • Resolution set to fixed
  • Status changed from new to closed

This patch fixes #9655 by trying to properly handle filenames with a '#' in them.

Branch: master
Changeset: e801178eb85018819a890d88b7761cc3d10544f1

Add Comment

Modify Ticket

Action
as closed .
The resolution will be deleted. Next status will be 'new'.
Author


E-mail address and user name can be saved in the Preferences.

 
Note: See TracTickets for help on using tickets.