Modify
Warning Please read the Ticket HowTo before creating or commenting on a ticket. Failure to do so may cause your ticket to be rejected or result in a slower response.

Opened 3 years ago

Closed 3 years ago

#9665 closed Bug Report - General (fixed)

Pause state confusion when changing source

Reported by: John Veness <John.Veness.mythtv@…> Owned by: markk
Priority: minor Milestone: 0.24.1
Component: MythTV - General Version: 0.24-fixes
Severity: medium Keywords:
Cc: Ticket locked: no

Description (last modified by wagnerrp)

Steps to reproduce:

1, Go into Watch Recordings
2, Start playback of any recording
3, Pause playback
4, Go into menu
5, Choose Source, Jump to Program, Recorded Program, and pick another recording
6, The chosen recording starts playing

At this point, although the chosen recording seems to be playing back OK, things aren't quite right. If you press "I" on the keyboard, there is no response (should be a progress bar). If you use the left or right cursor keys, instead of skipping by 30 or 5 seconds, only one frame (guessing) is skipped in either direction. If you press "P", instead of pausing, the OSD says "Play" and playback continues (a second press of "P" will pause).

I haven't looked at the code, but I think what is happening is that, despite the recording playing back, something "thinks" it is paused, which is why the "I" key has no response (as it doesn't when paused), why the press of "P" makes it think that it needs to start playing, and why the left and right cursor keys only skip one frame.

Attachments (2)

version_info (661 bytes) - added by wagnerrp 3 years ago.
fixes_0_24_pause.diff (17.5 KB) - added by markk 3 years ago.

Download all attachments as: .zip

Change History (7)

comment:1 Changed 3 years ago by markk

  • Milestone changed from unknown to 0.24.1
  • Owner set to markk
  • Status changed from new to accepted

comment:2 Changed 3 years ago by wagnerrp

  • Description modified (diff)

Changed 3 years ago by wagnerrp

comment:3 Changed 3 years ago by Mark Kendall

libmythtv: Use the actual MythPlayer? pause state

Remove the pause member variable from PlayerContext? and access the pause
state of the player directly. Fixes some inconsistencies in the pause
state and another step along the long road of removing PlayerContext?
entirely.

Refs #9665

Changeset: 8c18a320ac62b4921a0a57248a8aaa0e6d7732a4

Changed 3 years ago by markk

comment:4 Changed 3 years ago by markk

I've attached a modified version of the trunk fix that should apply cleanly and work with fixes/0.24. I will commit in a few days if no problems are reported in master.

comment:5 Changed 3 years ago by Github

  • Resolution set to fixed
  • Status changed from accepted to closed

libmythtv: Use the actual MythPlayer? pause state

Remove the pause member variable from PlayerContext? and access the pause
state of the player directly. Fixes some inconsistencies in the pause
state and another step along the long road of removing PlayerContext?
entirely.

Pimped from master 8c18a320ac62b4921a0a

Closes #9665

Changeset: 4068639223cf10eab3c63af8b57a1928b4c5965b

Add Comment

Modify Ticket

Action
as closed .
The resolution will be deleted. Next status will be 'new'.
Author


E-mail address and user name can be saved in the Preferences.

 
Note: See TracTickets for help on using tickets.