Inconsistent default / help text for Storage Group disk scheduler

[Robert Kulagowski]

One of the following two patches should be applied. Although we specify that Balanced Free Space is recommended for most users in the help text, the default value inserted into the database during the schema update isn't Balanced Free Space:

rkulagow@master:~/mythtv$ git diff
diff --git a/mythtv/libs/libmythtv/dbcheck.cpp b/mythtv/libs/libmythtv/dbcheck.cpp
index e0d17c5..e31028c 100644
--- a/mythtv/libs/libmythtv/dbcheck.cpp
+++ b/mythtv/libs/libmythtv/dbcheck.cpp
@@ -4865,7 +4865,7 @@ NULL
     if (dbver == "1241")
     {
        const char *updates[] = {
-"INSERT INTO settings ( value, data, hostname ) VALUES ( 'StorageScheduler', 'Combination', NULL );",
+"INSERT INTO settings ( value, data, hostname ) VALUES ( 'StorageScheduler', 'BalancedFreeSpace', NULL );",
 NULL
 };
         if (!performActualUpdate(updates, "1242", dbver))
diff --git a/mythtv/programs/mythbackend/config_backend_general.xml b/mythtv/programs/mythbackend/config_backend_general.xml
index b8b5882..ebeb22b 100644
--- a/mythtv/programs/mythbackend/config_backend_general.xml
+++ b/mythtv/programs/mythbackend/config_backend_general.xml
@@ -177,11 +177,11 @@
            range_min="4700" range_max="94000" step="4700" />
 -->
         <setting
-           value="StorageScheduler" default_data="BalancedFreeSpace"
+           value="StorageScheduler" default_data="Combination"
            setting_type="global" label="Storage Group Disk Scheduler"
            help_text="This setting controls how the Storage Group
                       scheduling code will balance new recordings across
-                      directories. 'Balanced Free Space' is the recommended
+                      directories. 'Combination' is the recommended
                       method for most users."
            data_type="select">
           <option display="Balanced Free Space" data="BalancedFreeSpace" />

[cpinkham]

This discrepancy is on purpose. The logic is explained in the commit that added that DB update. Prior to the changes on that date, the combination method was the only one available and there was no setting. In f7df5797, the new balanced free space and balanced disk I/O schedulers were added. The DB update was added in 4a63451d so that users upgrading from prior to f7df5797 would still retain their original storage balancing method. New users installing versions after 4a63451d would get the new recommended setting. We normally have a policy of not changing settings on users unless a feature is being removed.