Opened 10 years ago

Closed 10 years ago

#9810 closed Patch - Bug Fix (fixed)

QUERY_FREE_SPACE_SUMMARY missed in protocol change from 2 32bit numbers to 1 64 bit

Reported by: Gregory Moyer <moyerg@…> Owned by: beirdo
Priority: minor Milestone: 0.25
Component: MythTV - General Version: Master Head
Severity: medium Keywords:
Cc: Ticket locked: no


The protocol command QUERY_FREE_SPACE_SUMMARY was missed when the updates were made to change from sending 2 32 bit numbers to 1 64 bit number (commits 1508085eb3cf5f5b88af, c7de5d75cbe975db4b8e, and 64d448acdd27b0384748). The function MainServer::BackendQueryDiskSpace? was updated so that the last 2 items contain the total and used space (when allHosts is true) instead of the last 4. A patch is attached to correct mainserver.cpp.

As far as I can tell, only the Python binding is using this protocol command and it has already been updated to expect 2 values instead of 4.

Attachments (2)

query_free_space_summary.patch (700 bytes) - added by Gregory Moyer <moyerg@…> 10 years ago.
mythbackend_version.log (745 bytes) - added by Gregory Moyer <moyerg@…> 10 years ago.

Download all attachments as: .zip

Change History (4)

Changed 10 years ago by Gregory Moyer <moyerg@…>

Changed 10 years ago by Gregory Moyer <moyerg@…>

Attachment: mythbackend_version.log added

comment:1 Changed 10 years ago by Raymond Wagner

Milestone: unknown0.25
Owner: set to beirdo
Status: newassigned

comment:2 Changed 10 years ago by Github

Resolution: fixed
Status: assignedclosed


Seems that the summary message was missed in the conversion to 64bit from 2*32.

Fixes #9810

Signed-off-by: Gavin Hurlbut <ghurlbut@…>

Branch: master Changeset: 8456ea24b7994c30bc0a90996f72a74204250a8e

Note: See TracTickets for help on using tickets.