Modify
Warning Please read the Ticket HowTo before creating or commenting on a ticket. Failure to do so may cause your ticket to be rejected or result in a slower response.

Opened 3 years ago

Closed 3 years ago

#9860 closed Patch - Bug Fix (Fixed)

DVD: fixes for some problems with menu button highlighting

Reported by: linux@… Owned by: markk
Priority: minor Milestone: 0.25
Component: MythTV - DVD Playback Version: Master Head
Severity: medium Keywords:
Cc: Ticket locked: no

Description

Hi,

I have been looking at some problems I have been seeing with DVD playback, namely that for some DVDs the menu buttons never get highlighted, so you don't know which button is active.

The two main problems I found are the following:

  • the current menu button handling does not work if the menu button subtitle image is located anywhere else than the upper left corner of the screen because otherwise it will get the screen locations of the highlighted button wrong
  • currently the subtitle image background and the highlighted area are painted as two separate images; this produces incorrect results if a DVD uses button effects such as a greyed out area that becomes transparent when highlighted as the transparent foreground image will not undo the grey layer from the background image; to fix this the color of the highlighted area needs to be set in the background image directly

I have added a patch with corrections for this and one or two other smaller problems. I have created it as a patch series for better documentation of what is being corrected. It should be easily processed with 'git am'.

Please let me know if you have any questions.

Thanks and best wishes,

Martin.

Attachments (1)

dvdmenubuttons.patch (9.0 KB) - added by linux@… 3 years ago.
patch series for DVD menu button highlighting

Download all attachments as: .zip

Change History (7)

Changed 3 years ago by linux@…

patch series for DVD menu button highlighting

comment:1 Changed 3 years ago by markk

  • Milestone changed from unknown to 0.25
  • Status changed from new to accepted

comment:2 Changed 3 years ago by Github

DVDRingBuffer: Fix the dvd menu button height.

A definite improvement in a number of cases.

Refs #9860

Signed-off-by: Mark Kendall <mkendall@…>

Branch: master
Changeset: 2f899ffadb0bf8d13c30149ae06619df73a42ecd

comment:3 Changed 3 years ago by Github

DVDRingBuffer: Specify the stride for the dvd button QImage.

Refs #9860

Signed-off-by: Mark Kendall <mkendall@…>

Branch: master
Changeset: 2f52faef1ded62e474c44562ef66b100c6e57de4

comment:4 Changed 3 years ago by Github

DVD: Fix dvd button positioning.

Refs #9860

Signed-off-by: Mark Kendall <mkendall@…>

Branch: master
Changeset: 801aebf29793b955b53897bd383d5c83101b4434

comment:5 Changed 3 years ago by Github

DVD: Fix dvd button background handling.

Refs #9860

Signed-off-by: Mark Kendall <mkendall@…>

Branch: master
Changeset: 005276f8c4cd11203bb1482cc01759793ac43f8d

comment:6 Changed 3 years ago by markk

  • Resolution set to Fixed
  • Status changed from accepted to closed

Thanks Martin - some real improvements on a number of dvds here. Saved me a few days of head scratching.

Add Comment

Modify Ticket

Action
as closed .
The resolution will be deleted. Next status will be 'new'.
Author


E-mail address and user name can be saved in the Preferences.

 
Note: See TracTickets for help on using tickets.