patch: mythmetadatalookup --refresh-all-artwork can update the wrong recording

[Doug Haber <doug@…>]

Hey All,

mythmetatdatalookup --refresh-all-artwork calls "RemoteGetAllScheduledRecordings?(recordingList)" to get a list of recording rules. This list comes back as a list of ProgramInfo? objects even though on the backend it's really RecordingInfo? objects. This doesn't matter much, however, the backend has some logic to set the starttime/endtime to be the current date at midnight if the recording type isn't Single,Don't,Override,Timeslot or Weekly.

So if you're unlucky (like I was) and you have multiple recording rules on channel 123 that aren't one of the above types (e.g. Record All) and you happened to record something today at midnight on the same channel, then when pginfo->SaveInetref?() is called it will overwrite your recording's inetref with the one from the recording rule.

Even if you're not unlucky, it's still making unnecessary DB calls to update the recorded table when it shouldn't since it's inspecting a recording rule and not a recording . The attached patch makes sure that we only make the Save() calls if the programinfo is likely to actually be a program info, that is, it has start & end time that aren't equal.

Thanks!

Doug

[robertm]

Please try this patch instead. This should prevent your issue without the need for a hack that leaves updates of certain rule types unpredictable.

[robertm]

Update season, episode, inetref using rule id as well.

[doug@…]

This patch solves my issue.

Thanks for the quick response!
Doug

[Github]

Use RecID to verify that changed Season, Episode, and Inetref are correct.

Prevents metadata from being potentially saved to the wrong programinfo/recrule/recording.

Fixes the issue reported by Doug Haber in #9931. Fixes #9931.

Branch: master Changeset: e90f0240f8735dd0d7d5b25a8bc8703097c23b7a