Opened 9 years ago

Closed 9 years ago

Last modified 9 years ago

#9990 closed Patch - Bug Fix (fixed)

Ignore channels without xmltvid when guessing if the xmltv grabber has done something.

Reported by: dekarl@… Owned by: sphery
Priority: minor Milestone: 0.25
Component: MythTV - Mythfilldatabase Version: Master Head
Severity: medium Keywords:
Cc: Ticket locked: no


One of my sources gets 28 days of guide data on one channel via EIT and 21 days on other channels via XMLTV. So the grabber has no chance to change max(endtime) of this source and is always reported as "potentially failed".

Attached is a proof of concept patch that ignores channels without xmltvid (the grabber can't change them anyway)

Attachments (2)

0001-Ignore-channels-without-xmltvid-when-guessing-if-the.patch (2.7 KB) - added by dekarl@… 9 years ago.
0001-Ignore-channels-without-xmltvid-when-guessing-if-the.2.patch (2.7 KB) - added by dekarl@… 9 years ago.
the patch, rebased against lastest master

Download all attachments as: .zip

Change History (5)

Changed 9 years ago by dekarl@…

comment:1 Changed 9 years ago by dekarl@…

Thanks to superm1, I have tested the patch against latest master and it's working as designed. The false positives are gone wie the warning still intact when it's actually true.

Changed 9 years ago by dekarl@…

the patch, rebased against lastest master

comment:2 Changed 9 years ago by Github

Milestone: unknown0.25
Resolution: fixed
Status: newclosed

Improve check for whether mythfilldatabase inserted data.

Only consider channels which have an xmltvid when checking whether mythfilldatabase inserted any data. This will better handle error reporting for users who have sources with different channels using XMLTV (or Schedules Direct) and EIT.

Fixes #9990

Signed-off-by: Michael T. Dean <mdean@…>

Branch: master Changeset: a98783e19e07954c31a0148fbc2ef57d57dff077

comment:3 Changed 9 years ago by sphery

Owner: changed from stuartm to sphery
Note: See TracTickets for help on using tickets.