Opened 14 years ago

Closed 13 years ago

#9991 closed Bug Report - General (fixed)

Icon search for channels with "," in their name does not work

Reported by: dekarl@… Owned by: danielk
Priority: minor Milestone: 0.25
Component: MythTV - Mythtv-setup Version: Master Head
Severity: low Keywords:
Cc: Ticket locked: no

Description

Attaching the logo to channel 'NDR 90,3' does not work. The search returns a candidate '"NDR 90' without a logo. Lyngsat has it here ​http://www.lyngsat-logo.com/radiocountry/de.html It appears like the comma is treated as a separator somewhere.

Change History (2)

comment:1 Changed 14 years ago by dekarl@…

Now that I'm done I see there's a nice error reported to the console, too. That's where the part after the comma ends up. 

2011-08-17 18:49:11.041244 I  Fetch Icons for channel NDR 90,3
2011-08-17 18:49:16.084672 E  NetworkOperation Error on Finish: No server set to connect to (1): url: '3"'
2011-08-17 18:49:16.095192 E  Server returned an error status code 0 for url: 3"

Manually searching via ​http://services.mythtv.org/channel-icon/search?s=NDR and looking at ​https://github.com/MythTV/mythtv/blob/master/mythtv/programs/mythtv-setup/importicons.cpp#L465 makes me think that the csv extraction is broken.

The breakage in the csv parser makes quotes around a comma useless. (the quotes get nicely stripped from the string but have no function) This leaves escaping the "in string comma" with a backslash at services.mythtv.org as the easy fix (which should work for past releases instead of only future releases, too).

comment:2 Changed 13 years ago by Github

Milestone: unknown → 0.25
Resolution: → fixed
Status: new → closed

Fixes #9991. Replaces csv parser in icon downloader.

The existing code was overly complicated and didn't account for quotes.

Branch: master Changeset: f0deca75d6024ca36c0c5c26600eda4f846a8644

Note: See TracTickets for help on using tickets.