Opened 6 years ago

Closed 6 years ago

#11047 closed Bug Report - Crash (Fixed)

Possible mythuiimage decref segfault

Reported by: trebor_s@… Owned by: stuartm
Priority: major Milestone: 0.26.1
Component: Plugin - MythMusic Version: Master Head
Severity: low Keywords:
Cc: Ticket locked: no

Description

The call to im->DecrRef?() in mythuiimage.cpp in the customEvent method can cause a segfault. I had one segfault when I was listening to internet radio with the mythmusic plugin and it tried to fetch the Deutschland Radio logo. Adding a check "if (im)" fixed that. Patch attached.

Attachments (1)

mythuiimage_decref.patch (540 bytes) - added by anonymous 6 years ago.

Download all attachments as: .zip

Change History (8)

Changed 6 years ago by anonymous

Attachment: mythuiimage_decref.patch added

comment:1 Changed 6 years ago by stuartm

Component: MythTV - GeneralPlugin - MythMusic
Milestone: unknown0.26
Owner: set to stuartm
Priority: minorcritical
Status: newaccepted

comment:2 Changed 6 years ago by stuartm

The patch treats the symptom but not the root cause. That pointer should not be null and I'll need to do some digging to discover exactly how it came to be deleted.

comment:3 Changed 6 years ago by stuartm

Milestone: 0.260.26.1

comment:4 Changed 6 years ago by Stuart Morgan <smorgan@…>

In b4deb185994d6388b55cea18aa3e861c71541101/mythtv:

Prevent a segfault in MythUIImage, this doesn't fix the root cause of the problem but at least we won't crash. Refs #11047

comment:5 Changed 6 years ago by Stuart Morgan <smorgan@…>

In 178ea5aaa562845e3685ffeff585ea57c6014a64/mythtv:

Prevent a segfault in MythUIImage, this doesn't fix the root cause of the problem but at least we won't crash. Refs #11047

comment:6 Changed 6 years ago by stuartm

Priority: criticalmajor
Severity: mediumlow

comment:7 Changed 6 years ago by stuartm

Resolution: Fixed
Status: acceptedclosed

Too many other things to worry about, so closing this.

Note: See TracTickets for help on using tickets.