Opened 6 years ago

Closed 5 years ago

#11890 closed Developer Task (Fixed)

inetref column in record and recordedartwork tables are inadequate

Reported by: mythtv@… Owned by:
Priority: minor Milestone: 0.27.4
Component: MythTV - Mythmetadatalookup Version: Unspecified
Severity: medium Keywords:
Cc: Ticket locked: no

Description

There is code in libs/metadatalookup.cpp that tries to guess what metadata grabber to use for a given inetref. It's complex and fails if you have a TV programme with season/episode set to 0.

I think a better solution would be to add a grabber column so the code does not need heuristics. After all the grabber is known when the inetref is found unless it's an inetref you type manually.

Also this will support more grabbers then just the two embedded in the code.

Change History (6)

comment:1 Changed 6 years ago by stuartm

Milestone: unknown0.28
Type: Bug Report - GeneralDeveloper Task

An even simpler solution is just to prefix the inetref with a grabber specific identifier. e.g. TMDB_123456, TVDB_45346, IMDB_tt0113243

comment:2 Changed 6 years ago by mythtv@…

Kind of agree but IMDB_xxx will need a lookup somewhere that goes from IMDB_ to grabber/imdb.py. Hopefully in a nice simple bit of python.

comment:3 Changed 6 years ago by Raymond Wagner

There is no imdb.py, and it wouldn't make sense to require grabbers have the ability grabbers call other grabbers. Either alter the version output of the grabber to specify a tag that gets prepended by the metadata library, or just have the metadata library prepend the filename itself. If no one else has started on this yet, I'll take care of it this weekend.

comment:4 Changed 6 years ago by dekarl@…

I just store (pseudo) urls in my guide database like

http://www.themoviedb.org/movie/35619

http://thetvdb.com/?tab=episode&seriesid=260426&seasonid=495783&id=4354633&lid=14

There are other suggestions for nicer pseudo urls available e.g. https://docs.metabroadcast.com/display/ATLAS/The+TVDB

Using working urls makes it super easy to go upstream to fix bad data, but for MythTVs use case the pseudo urls from the second sample might be nicer, although it uses three urls per episode (episode id, season id, series id).

comment:5 Changed 5 years ago by Frank Phillips <fphillips81@…>

Following #12149 (thank you Raymond), the prepended grabber name has been implemented in recorded.inetref column.

comment:6 Changed 5 years ago by Raymond Wagner

Milestone: 0.280.27.4
Resolution: Fixed
Status: newclosed
Note: See TracTickets for help on using tickets.