Opened 6 years ago

Closed 5 years ago

#11954 closed Patch - Feature (fixed)

save card input name for recordings

Reported by: George Nassas <gnassas@…> Owned by: gigem
Priority: minor Milestone: 0.28
Component: MythTV - Scheduling Version: Master Head
Severity: medium Keywords:
Cc: Ticket locked: no

Description

I've been running this in production for a while without problems. It's pretty straitforward.

I'm not sure if there's a way to retrieve the cardinput for existing recordings to update those rows ex post facto. Suggestions welcome.

The device name isn't saved for live tv recorded rows unless you elect to make them permanent recordings (ie, by pressing "R"). I can't tell if this is a shortcoming on my side or the live tv code.

The patch also includes an update Stuart missed in the perl bindings' outgoing myth protocol message - he updated the incoming code but not the outgoing.

Attachments (10)

recinput.schema.patch (1.3 KB) - added by George Nassas <gnassas@…> 6 years ago.
schema update
recinput.mythtv.v0.28-pre-461-g1dd14ea.patch (27.9 KB) - added by George Nassas <gnassas@…> 6 years ago.
recinput.mythweb.v0.28-pre-10-gbb41293.patch (4.2 KB) - added by George Nassas <gnassas@…> 6 years ago.
recinput.mythweb.v0.28-pre-9-g61f14b9.patch (2.4 KB) - added by George Nassas <gnassas@…> 6 years ago.
supersedes recinput.mythweb.v0.28-pre-10-gbb41293.patch
recinput.mythtv.v0.28-pre-519-gd8c710d.patch (28.2 KB) - added by George Nassas <gnassas@…> 6 years ago.
supercedes recinput.mythtv.v0.28-pre-461-g1dd14ea.patch
recinput.mythtv.v0.28-pre-912-g11e65df.patch (28.2 KB) - added by George Nassas <gnassas@…> 6 years ago.
supersedes recinput.mythtv.v0.28-pre-719-g8aefe1b.patch
recinput.mythtv.v0.28-pre-1041-ga0a32ef.patch (28.2 KB) - added by George Nassas <gnassas@…> 6 years ago.
rebase patch to head as of March 27, 2014
recinput.mythtv.v0.28-pre-1480-g7265c8f.patch (28.6 KB) - added by gnassas@… 5 years ago.
rebase to reflect recordedid change
recinput.mythweb.v0.28-pre-22-g9811898.patch (2.6 KB) - added by gnassas@… 5 years ago.
rebase to reflect recordedid change
recinput.mythweb.v0.28-pre-22-g9811898.2.patch (2.3 KB) - added by gnassas@… 5 years ago.
retrieve input name from recorded

Download all attachments as: .zip

Change History (19)

Changed 6 years ago by George Nassas <gnassas@…>

Attachment: recinput.schema.patch added

schema update

Changed 6 years ago by George Nassas <gnassas@…>

Changed 6 years ago by George Nassas <gnassas@…>

Changed 6 years ago by George Nassas <gnassas@…>

supersedes recinput.mythweb.v0.28-pre-10-gbb41293.patch

Changed 6 years ago by George Nassas <gnassas@…>

supercedes recinput.mythtv.v0.28-pre-461-g1dd14ea.patch

comment:1 Changed 6 years ago by George Nassas <gnassas@…>

Apologies for the patch foolishness. I had the wrong branch checked out.

comment:2 Changed 6 years ago by gigem

Milestone: unknown0.28
Status: newassigned

comment:3 Changed 6 years ago by gnassas@…

Looks like this needs a bit more work - the other day I had a failed recording but the tuner was not saved and, of course, failed recording tuner info is the whole point of this. Looks like my assignment isn't early enough in the process so I'm going to take another look and update the patch. Might be a week or two... in between merry making excursions.

comment:4 Changed 6 years ago by gnassas@…

A brief update: I finally shook loose some time and found a spot to save the input name just after tuning begins which will make it available even when recording ultimately fails. It'll take another week or two to find time to amend the patch, hopefully the timing works out to include this as part of 0.28.

Changed 6 years ago by George Nassas <gnassas@…>

supersedes recinput.mythtv.v0.28-pre-719-g8aefe1b.patch

comment:5 Changed 6 years ago by George Nassas <gnassas@…>

I think this patch is ready for review. It still doesn't save the input name for live tv recordings but I don't think that's very important and anyway it's probably a bug in how live tv works.

One subtle change is the recording host is now made available to themes even when a recording fails. When you're analyzing why a recording might have failed in a multi BE setup it's probably helpful to know where the input was located.

Changed 6 years ago by George Nassas <gnassas@…>

rebase patch to head as of March 27, 2014

Changed 5 years ago by gnassas@…

rebase to reflect recordedid change

Changed 5 years ago by gnassas@…

rebase to reflect recordedid change

comment:6 Changed 5 years ago by David Engel <dengel@…>

In 213c622a1fc19f08167df25ef131f4e66d693e05/mythtv:

Added support for saving the recording input name in the recorded
table.

This makes it possible to identify on which tuner a recording was made
after it was recorded. This can be very useful in diagnosing
recurring problems with a tuner that aren't noticed right away. The
input name is used rather than the input number because it is expected
to be more user friendly and useful, especially if the tuners have
been renumbered since the recording was made.

This is based on patches submitted by George Nassas.

Refs #11954

comment:7 Changed 5 years ago by gigem

Status: assignedinfoneeded

George, I'm sorry for not getting to this sooner. Thanks for your patches. I took a slightly different approach because I didn't want to add another field to the ProgramInfo? object. Could you please revise your mythweb patch to work with this approach?

Changed 5 years ago by gnassas@…

retrieve input name from recorded

comment:8 in reply to:  7 Changed 5 years ago by gnassas@…

Replying to gigem:

Could you please revise your mythweb patch to work with this approach?

Done.

I added a new title when I show the input name on the program's details page but I'm not sure if it's my job to add it to the different *.lang files or that happens automatically after a commit or what. Right now program details shows "!NoTrans: Input Name!!:" which looks unfinished.

comment:9 Changed 5 years ago by David Engel <david@…>

Resolution: fixed
Status: infoneededclosed

In 0fee55c716d3b428cc1987394eb02a7b0192ab2c/mythweb:

Read the recording input name from the recorded table.

Thanks to George Nassas for the patch.

Fixes #11954

Note: See TracTickets for help on using tickets.