Opened 13 years ago

Closed 5 years ago

#2224 closed defect (Fixed)

Pin coded recordings shown in Jump to Program OSD

Reported by: stuartm Owned by: stuartm
Priority: minor Milestone: 0.20
Component: mythtv Version: head
Severity: medium Keywords:
Cc: Ticket locked: no

Description

Recordings from pin coded recording groups are shown in the Jump to Program OSD without requiring a pin. This functionality was eventually intended but it's now too late for 0.20, so we need a temporary solution.

I've attached a patch which limits the menu to containing recordings from the same group as the currently playing recording. This cripples the feature a little but will prevent minors accessing stuff they shouldn't.

Unless someone can think of a better solution for 0.20, this will have to do.

Attachments (2)

jump_program_hack.diff (544 bytes) - added by stuartm 13 years ago.
2224.diff (758 bytes) - added by mythtv@… 5 years ago.

Download all attachments as: .zip

Change History (8)

Changed 13 years ago by stuartm

Attachment: jump_program_hack.diff added

comment:1 Changed 13 years ago by stuartm

(In [10937]) Limits the "Jump to Program" osd menu to recordings from the same group as the currently playing one.

This is a temporary fix until support for entering pin codes is written.

Refs #2224

comment:2 Changed 13 years ago by stuartm

Milestone: 0.20unknown

comment:3 Changed 12 years ago by stuartm

Milestone: unknown0.20
Owner: changed from kkhupal to stuartm

comment:4 Changed 12 years ago by stuartm

Resolution: fixed
Status: newclosed

Changed 5 years ago by mythtv@…

Attachment: 2224.diff added

comment:5 Changed 5 years ago by mythtv@…

Resolution: fixed
Status: closednew

At some point in the last 7 years there has been a regression, and this is now a problem once more, at least in 0.27. It is once again possible to access all recordings, even ones that require a different PIN, by way of the Jump to Program OSD.

I'm attaching an untested patch which I think accomplishes what the original patch to 0.20 did, but I do think the better thing to do would be to ask the user for a PIN, as mentioned above.

comment:6 Changed 5 years ago by sphery

Resolution: Fixed
Status: newclosed

Please open a new ticket for new issues, even if they are regressions (and feel free to reference this or any other relevant tickets on your new ticket).

Note: See TracTickets for help on using tickets.