Opened 13 years ago

Closed 11 years ago

#2239 closed enhancement (wontfix)

Patch to accept remote buttons as logical identifiers.

Reported by: navahogunleg@… Owned by: Isaac Richards
Priority: minor Milestone: 0.22
Component: mythtv Version: head
Severity: medium Keywords:
Cc: Ticket locked: no

Description

This patch allows MythTV to accept remote buttons (coming from LIRC) as logical identifiers. So in stead of configuring LIRC to map a button to a 'keypress', this patch will make the configured identifier to be correctly interpreted by Myth. ( As discussed in this thread: http://www.gossamer-threads.com/lists/mythtv/dev/207002#207002 )

Old way: begin prog = mythtv button = TV repeat = 3 config = X this keypress would reach Myth end

New way: begin prog = mythtv button = TV repeat = 3 config = remoteTV end

I wrote it so that if, in lircrc, a single character is found, this will still be interpreted as a keypress (i.e. it's downwards compatible).

(There's a known problem however, when Myth requests user input in an editbox, one hits a remote button, the text-identifier of that button will be inserted in that edit-box.)

Supplied is also the patch to recognise these in MythControls? so one can actually configure remote keypresses.

Attachments (7)

mythtv-lirc-20060824.diff (22.8 KB) - added by anonymous 13 years ago.
mythcontrols-20060824.diff (3.9 KB) - added by anonymous 13 years ago.
mythcontrols-20060910.diff (3.9 KB) - added by navahogunleg@… 13 years ago.
Updated, bugfixed version: I noticed today MythControls? wasn't accepting regular keys now due to a wrongly placed 'else'. :]
myth_lirc_latest.diff.libmyth (3.5 KB) - added by navahogunleg@… 12 years ago.
Patch to make remoteXXXX identifiers work again in SVN version (using Qt4) [patch split up into files because of too many local changes]
myth_lirc_latest.diff.libmythtv (777 bytes) - added by navahogunleg@… 12 years ago.
See comment above.
mythkeysequence.h (2.6 KB) - added by navahogunleg@… 12 years ago.
New mythkeysequence.h & .cpp using Qt4, and using QStringList in stead of own (buggy) parsing routine.
mythkeysequence.cpp (4.6 KB) - added by navahogunleg@… 12 years ago.
See comment above (mythkeysequence.* files should reside in libmyth/).

Download all attachments as: .zip

Change History (13)

Changed 13 years ago by anonymous

Attachment: mythtv-lirc-20060824.diff added

Changed 13 years ago by anonymous

Attachment: mythcontrols-20060824.diff added

comment:1 Changed 13 years ago by mythtv@…

See ticket #757 for an implementation of a very similar idea. Certainly, if this patch is accepted, #757 should be closed (and vice-versa, although the other ticket is old enough that I do not expect #757 to be accepted).

comment:2 Changed 13 years ago by stuartm

Milestone: 0.21
Owner: changed from Isaac Richards to stuartm

comment:3 Changed 13 years ago by stuartm

The approach used in #757 is slightly different in that it removes the need for a lircrc file. Neither these patches nor #757 will be used in their current form but I'll borrow code/ideas from both for the final implementation.

Changed 13 years ago by navahogunleg@…

Attachment: mythcontrols-20060910.diff added

Updated, bugfixed version: I noticed today MythControls? wasn't accepting regular keys now due to a wrongly placed 'else'. :]

comment:4 Changed 12 years ago by danielk

Milestone: 0.210.22
Version: head

comment:5 Changed 12 years ago by stuartm

Owner: changed from stuartm to Isaac Richards
Status: newassigned

Changed 12 years ago by navahogunleg@…

Patch to make remoteXXXX identifiers work again in SVN version (using Qt4) [patch split up into files because of too many local changes]

Changed 12 years ago by navahogunleg@…

See comment above.

Changed 12 years ago by navahogunleg@…

Attachment: mythkeysequence.h added

New mythkeysequence.h & .cpp using Qt4, and using QStringList in stead of own (buggy) parsing routine.

Changed 12 years ago by navahogunleg@…

Attachment: mythkeysequence.cpp added

See comment above (mythkeysequence.* files should reside in libmyth/).

comment:6 Changed 11 years ago by danielk

Resolution: wontfix
Status: assignedclosed

Stuart M may use some ideas from this, but this will not be committed as is. See very old discussions on mailing list as to why...

Note: See TracTickets for help on using tickets.