Opened 12 years ago

Closed 12 years ago

#2945 closed patch (fixed)

Patch to add better feedback on LCD during DVD playback

Reported by: maillists@… Owned by: skamithi
Priority: minor Milestone: unknown
Component: mythtv Version: head
Severity: low Keywords: lcd dvd playback
Cc: Ticket locked: no

Description

Patch to improve information displayed on LCD when playing a DVD.

Does the following:

  • Improves retrieval of DVD name by using a different location (from that of the included libdvdnav) if the name is encoded the 16bit notation. Alternative location gleemed from lsdvd source. If no displayable name can be found uses a default of "DVD". Strips trailing spaces and replaces underscores with spaces.
  • If in a menu (as detected by IsInMenu?()) displays DVD Name and indication of being in a menu.
  • Otherwise displays DVD Name, Title number and its length, Chapter number and the number of chapters in the title.
  • Doesn't display the progress bar when in a Menu - was previously stuck at 100% complete.

Leverages the switchToChannel and associated functionality to do this (ie. lcdCallSign, lcdTitle and lcdSubtitle)

Not sure if I've done the right thing with the tr() calls.

Attachments (1)

DVDLCDInfo-diff.txt.gz (1.9 KB) - added by maillists@… 12 years ago.
gzip of patch

Download all attachments as: .zip

Change History (6)

Changed 12 years ago by maillists@…

Attachment: DVDLCDInfo-diff.txt.gz added

gzip of patch

comment:1 Changed 12 years ago by skamithi

Owner: changed from Isaac Richards to skamithi

comment:2 Changed 12 years ago by maillists@…

Severity: mediumlow
Type: defectpatch

comment:3 Changed 12 years ago by skamithi

(In [12576]) Refs #2945: internal dvd player: Improve retrieval of the dvd title.

comment:4 Changed 12 years ago by skamithi

Status: newassigned

comment:5 Changed 12 years ago by skamithi

Resolution: fixed
Status: assignedclosed

(In [12607]) Closes #2945. commit patch to add better feedback on LCD during dvd playback.

Note: See TracTickets for help on using tickets.