Opened 12 years ago

Closed 12 years ago

Last modified 12 years ago

#3180 closed enhancement (fixed)

EIT fixup routine for dvb-c netherlands

Reported by: anonymous Owned by: Stuart Auchterlonie
Priority: minor Milestone: 0.21
Component: dvb Version: head
Severity: medium Keywords: eit dvb-c netherlands
Cc: Ticket locked: no

Description

I created a working eit fixup routine for dvb-c in the Netherlands (provider @Home). Testing it here for about two weeks. Everything is working quite allright except for year and director in movies. I cannot figure out what exactly is wrong (I presume it's the regexp...). I am posting the patch so people could test it and give some feedback about the code (as this is my first code ever!), don't know if everything is really efficient. Suggestions are welcome. Many thanks to Stuart A. for getting me started.

Attachments (2)

eit-nl.diff (11.1 KB) - added by petermartens@… 12 years ago.
ticket3180-years-n-director.dff (1.0 KB) - added by Stuart Auchterlonie 12 years ago.
Possible improvement to detection of years and directors

Download all attachments as: .zip

Change History (6)

Changed 12 years ago by petermartens@…

Attachment: eit-nl.diff added

comment:1 Changed 12 years ago by Stuart Auchterlonie

Owner: changed from danielk to Stuart Auchterlonie

comment:2 Changed 12 years ago by Stuart Auchterlonie

The year is formatted in two ways:

year1: uit 1985
year2: (US/1999)

The director looks like:

van Alan J. Pakula (where i tried to catch van followed by a space and at least two words starting with a capital (or a capital followed by a dot).


So, I think the regexps should be

m_nlYear1("\\s+uit\\s\\d{4}");
m_nlYear2("\\s\\([a-zA-Z]+/\\d{4}\\)");
m_nlDirector("\\svan\\s[A-Z][a-zA-Z]+\\s([A-Z]\\.\\s|[A-Z][a-zA-Z]+\\s)+");

Stuart

comment:3 Changed 12 years ago by Stuart Auchterlonie

Resolution: fixed
Status: newclosed

(In [13183]) Closes #3180. Adds eit fixup for dvb-c in the Netherlands. Original patch by Peter Martens.

The year and director probably won't be detected correctly, as per Peter's original patch. I've added what i think is the correct regexps to the ticket for them.

I'll add a patch shortly that can be with these regexps so it can be more easily tested by those with the service.

Please reopen the ticket if you have an updated patch that fixes the detection of year and director.

Changed 12 years ago by Stuart Auchterlonie

Possible improvement to detection of years and directors

comment:4 Changed 12 years ago by Stuart Auchterlonie

Patch added to hopefully improve the detection of years and directors. Feedback welcomed.

Note: See TracTickets for help on using tickets.