Opened 12 years ago

Closed 11 years ago

#3676 closed enhancement (fixed)

Mythmusic enhancement - repeat/shuffle icon support - album art in playback screen

Reported by: anonymous Owned by: paulh
Priority: minor Milestone: 0.21
Component: mythmusic Version: head
Severity: medium Keywords:
Cc: Ticket locked: no

Description

This is a proposed enhancement to Mythmusic. Adds the ability to show icons for the shuffle and repeat modes. Adds ability to show album art in playback screen -- this is separate from visualization - in fact it is supported through theme file, you can specify both the album art and visualization in the playback screen.

Shuffle/Repeat?


Inspired by patch by eskil patch at http://www.eskil.org/mythtv/ (See http://www.eskil.org/mythtv/shots/musictheme.png for sample screenshot) (You'll also want to grab the shuffle/repeat icons from http://www.eskil.org/mythtv/patches/musictheme.tar.gz) Patch is implemented differently such that all current themes should be compatible. When the shuffle button (1) is press, it will cycle through the icons "icon-shuffle-random",intelligent and smart. I place them over top of one another. To use this feature need to add to music-ui.xml:

<image name="icon-shuffle-random" draworder="3" fleximage="no">

<filename>music/mb-icon-shuffle.png</filename> <position>0,5</position>

</image> <image name="icon-shuffle-intelligent" draworder="3" fleximage="no">

<filename>music/mb-icon-shuffle-smart.png</filename> <position>0,5</position>

</image> <image name="icon-shuffle-album" draworder="3" fleximage="no">

<filename>music/mb-icon-shuffle-album.png</filename> <position>0,5</position>

</image> <image name="icon-shuffle-off" draworder="3" fleximage="no">

<filename>music/mb-icon-shuffle-off.png</filename> <position>0,5</position>

</image> <image name="icon-repeat-track" draworder="3" fleximage="no">

<filename>music/mb-icon-repeat-track.png</filename> <position>50,5</position>

</image> <image name="icon-repeat-all" draworder="3" fleximage="no">

<filename>music/mb-icon-repeat-all.png</filename> <position>50,5</position>

</image> <image name="icon-repeat-off" draworder="3" fleximage="no">

<filename>music/mb-icon-repeat-off.png</filename> <position>50,5</position>

</image>

You can still keep the four buttons at the bottom of the screen also, the text in the shuffle and repeat buttons update as useful when pressing the shuffle or repeat key. Patch is implemented to have to impact on current themes, just need to add something like above to use this.

Albumart


I prefer to see the albumart instead of the visualizer in the playback screen. So I added an option through music-ui.xml to show this. This way it is fully compatible with existing themes (you'll see no change until music-ui.xml is modified). In fact you can show both albumart and visualizer window simutaneously. To see the albumart, add this to music-ui.xml:

<image name="albumart" draworder="3" fleximage="no">

<position>37,11</position> <staticsize>118,122</staticsize>

</image>

You can keep the blackhole option for the visualizer. The albumart will automatically change on song change. Of course this option only works in the playback screen, has no impact on the full-screen visualizer and no impact the banner. You won't see any change or impact to current themes unless you add something like above.

Attachments (3)

mythmusic.patch (7.8 KB) - added by maverik044 12 years ago.
mythmusic-albumart.patch (2.7 KB) - added by maverik044 12 years ago.
Patch to show album art on playback screen
mythmusic-shuffle_repeat.patch (7.2 KB) - added by maverik044 12 years ago.
patch to allow shuffle-repeat icons in playback screen

Download all attachments as: .zip

Change History (10)

Changed 12 years ago by maverik044

Attachment: mythmusic.patch added

comment:1 Changed 12 years ago by stuartm

Milestone: unknown0.21
Owner: changed from Isaac Richards to stuartm
Version: unknownhead

comment:2 Changed 12 years ago by stuartm

In future, could you create separate patches for separate features? Thanks.

comment:3 Changed 12 years ago by maverik044

Updated patches attached:

  1. Separated as requested
  2. Fixed some stupid errors that causes seg faults when used with themes that don't use the new features
  3. Removed ugly "tabs" in code.
  4. Fix album art display, if art of a smaller size is shown after a larger one, part of the larger one can be seen -- FIXED

Changed 12 years ago by maverik044

Attachment: mythmusic-albumart.patch added

Patch to show album art on playback screen

Changed 12 years ago by maverik044

patch to allow shuffle-repeat icons in playback screen

comment:4 Changed 11 years ago by stuartm

Shuffle/Repeat? icons - I'd like to see something along these lines in mythmusic, I've already added a version of this to trunk but at this point I think it's best to wait until mythmusic is converted to mythui. The statetype in mythui would allow all sorts of fun to be had with this idea and I'd rather invest time in that.

I can't really decide whether there is sufficient justification for having a separate albumart blackhole in addition to the visualiser blackhole and albumart visualiser. Although I'm sure that some people would want both, the biggest complaint from themers about the mythmusic screen is the lack of space for the amount of information they are expected to display.

If Paul wants to take this ticket, I'll let him make the call.

comment:5 Changed 11 years ago by Bill <level42@…>

Hi, I'm the author of the patch. I'm quite happy with the current SVN implemetation of the shuffle/repeat and have adapted my personal theme to the current SVN implementation.

Please consider adding the albumart one, I prefer to use show this rather than the visualizer. The way it is coded, it is fully compatible with existing themes, it is completely optional and will only show if the themer wishes to.

In future I plan to look at using the visualizer to show a small spectrum analyzer on the playback screen.

comment:6 Changed 11 years ago by paulh

Owner: changed from stuartm to paulh
Status: newaccepted

comment:7 Changed 11 years ago by paulh

Resolution: fixed
Status: acceptedclosed

(In [15780]) Adds an optional albumart image on the MythMusic playback screen. This just gives themers a little bit of flexibility on what to show on screen. You can have either the albumart or visualiser or both or neither if you wish.

Patch by maverik044. I modified it slightly so if no cover image is available it will show the mm_nothumb.png image like the mini-player.

The repeat/shuffle icon support will be added when MythMusic is converted to the new UI.

Closes #3676.

Note: See TracTickets for help on using tickets.