Opened 12 years ago

Closed 8 years ago

#4504 closed enhancement (fixed)

Extend guide to show unavailable channels in a different color (multirec)

Reported by: Mark Buechler <Mark.Buechler@…> Owned by: stuartm
Priority: minor Milestone: 0.25
Component: MythTV - User Interface Library Version: head
Severity: medium Keywords:
Cc: Ticket locked: no

Description

This patch extends the idea of showing unavailable channels in the channel column with a "X" buy giving those channels a different theme-able color. It also prevents the guide from closing if you select an unavailable channel. In order for this to work, the following needs added to your theme in the "guide" container:

<unavailablecolor>#ff0000</unavailablecolor>

Attachments (3)

guide_unav.diff (11.6 KB) - added by Mark Buechler <Mark.Buechler@…> 12 years ago.
The patch
4504-v1.patch (22.9 KB) - added by danielk 12 years ago.
Mark's patch + theme parts of patch.
4504-v2.patch (22.9 KB) - added by danielk 12 years ago.
Updated patch

Download all attachments as: .zip

Change History (15)

Changed 12 years ago by Mark Buechler <Mark.Buechler@…>

Attachment: guide_unav.diff added

The patch

comment:1 Changed 12 years ago by Mark Buechler <Mark.Buechler@…>

Note, the same problem in 4503 still exists here.

comment:2 Changed 12 years ago by danielk

Milestone: unknown0.21
Owner: changed from Isaac Richards to danielk
Status: newassigned

comment:3 Changed 12 years ago by danielk

Status: assignedinfoneeded

Mark, can you update this to apply to the latest svn?

The code in isUnavailable() probably needs changing to match the fix where chinfo is repulled when trying alternatives with the same channum.

comment:4 Changed 12 years ago by Mark Buechler <Mark.Buechler@…>

Daniel, can you point me to that patch?

Thanks, Mark.

comment:5 Changed 12 years ago by danielk

Status: infoneededassigned

Sorry, this was a local patch. Janne has already committed a different fix, so there is no need for any updated patch from you. I'm testing this now.

comment:6 Changed 12 years ago by danielk

(In [15633]) Refs #4504. Greys out text of unavailable channels, yellows text of favorite channels in EPG.

Changed 12 years ago by danielk

Attachment: 4504-v1.patch added

Mark's patch + theme parts of patch.

comment:7 Changed 12 years ago by danielk

Milestone: 0.21unknown

Mark, I like the concept but I think this requires a little more work. As is, this color color is overridden if something is marked with another color (say for a scheduled recording). Also the suggested 'red' is also the same color as the news item category color. I think it would make more sense if this modified the existing saturation or intensity color, so that all scheduled items would shift noticibly toward grey when the channel is in unavailable.

In the meantime, I've implemented a 'graying' of the channel name text in the EPG for unavailable channels (and a yellowing for favorite channels).

Changed 12 years ago by danielk

Attachment: 4504-v2.patch added

Updated patch

comment:8 Changed 10 years ago by stuartm

Component: mythtvMythTV - User Interface Library
Milestone: unknown0.23
Owner: changed from danielk to stuartm
Status: assignedaccepted

I'll see how we can work this into a mythui guide using statetypes, so the exact representation would be up to the themer.

comment:9 Changed 10 years ago by stuartm

Milestone: 0.230.24

comment:10 Changed 9 years ago by robertm

Milestone: 0.240.25

Unlikely to be touched for .24

comment:11 Changed 9 years ago by stuartm

Milestone: 0.25

Milestone 0.25 deleted

comment:12 Changed 8 years ago by Github

Resolution: fixed
Status: acceptedclosed

GuideGrid? was missing statetype corresponding to existing text state. Fixes #4504

Branch: master Changeset: 3e7f41e1f17c2f0ae86ec26fa4f3a3b1aef8f957

Note: See TracTickets for help on using tickets.