Opened 11 years ago

Closed 10 years ago

#5910 closed patch (fixed)

Fix "Automatically mark a recording as watched" to work with prompts enabled

Reported by: sphery <mtdean@…> Owned by: Shane Shrybman
Priority: minor Milestone: 0.22
Component: mythtv Version: head
Severity: medium Keywords: easy
Cc: Ticket locked: no

Description

The "Automatically mark a recording as watched" setting only works when prompts (either "Action on playback exit" or "Prompt at end of recording", depending on how you exit playback) are disabled. There used to be an option in the exit prompt dialog, "Mark as watched and go to the menu," but the option was removed from the exit prompt in [11253].

Because the prompt had an option to mark a show as watched, the code was written so that it did not automatically mark shows as watched if prompts were enabled. Now that the option no longer exists, it makes sense to automatically mark recordings as watched even if prompts are enabled (assuming the "Automatically mark a recording as watched" is enabled). If we don't do this, users who enable prompts think the "Automatically mark ..." setting isn't working.

The attached patch fixes the issue with prompts and several other exit conditions (including through network control, when using JUMPPREV or JUMPPROG). I tested each exit condition with each setting for the prompts and they work (at least, as I would expect). The approach I took was to allow shows to be marked as watched consistently (basically when not deleting the show) so the user doesn't have to second-guess whether to unmark a show--i.e. if you exit near the end and have the "Automatically mark..." setting enabled, it will be marked as watched, so if you want to keep the show, unmark it or disable the setting.

First patch is for 0.21-fixes. I'm currently converting to/testing with trunk.

Attachments (6)

mythtv-0.21-fixes-5910-fix_automatically_mark_as_watched_with_prompts.patch (3.5 KB) - added by sphery <mtdean@…> 11 years ago.
Patch for 0.21-fixes
mythtv-0.21-fixes-5910-fix_automatically_mark_as_watched_with_prompts.2.patch (3.5 KB) - added by sphery <mtdean@…> 11 years ago.
patch for trunk
mythtv-5910-fix_automatically_mark_as_watched_with_prompts.patch (3.5 KB) - added by sphery <mtdean@…> 11 years ago.
This is the real patch for trunk. (Can't use a mouse/file-selection dialog.)
mythtv-5910-fix_automatically_mark_as_watched_with_prompts.2.patch (3.8 KB) - added by sphery <mtdean@…> 11 years ago.
Updated patch for recent changes to trunk.
mythtv-5910-fix_automatically_mark_as_watched_with_prompts.3.patch (3.8 KB) - added by sphery <mtdean@…> 10 years ago.
Updated for recent changes to trunk
5910_PrepareToExitPlayer.diff (7.7 KB) - added by Shane Shrybman 10 years ago.

Download all attachments as: .zip

Change History (11)

Changed 11 years ago by sphery <mtdean@…>

Patch for 0.21-fixes

Changed 11 years ago by sphery <mtdean@…>

patch for trunk

Changed 11 years ago by sphery <mtdean@…>

This is the real patch for trunk. (Can't use a mouse/file-selection dialog.)

comment:1 Changed 11 years ago by sphery <mtdean@…>

mythtv-5910-fix_automatically_mark_as_watched_with_prompts.patch is the patch for trunk. If testing it, there's a segfault in the VERBOSE when using JUMPPROG if -vb important is enabled. The segfault existed before the patch, so is unrelated.

comment:2 Changed 11 years ago by sphery <mtdean@…>

FWIW, the unrelated segfault in trunk when using JUMPPROG that I mentioned is the one Daniel fixed (in mythtv-vid) with [19377] (and his mentioning he was working on it is why I didn't report it in a ticket or post the backtrace). So, if you'd like to verify mythtv-5910-fix_automatically_mark_as_watched_with_prompts.patch isn't causing the segfault, it can be done in mythtv-vid (though may require updating the patch for mythtv-vid).

Changed 11 years ago by sphery <mtdean@…>

Updated patch for recent changes to trunk.

Changed 10 years ago by sphery <mtdean@…>

Updated for recent changes to trunk

comment:3 Changed 10 years ago by laga

Keywords: easy added
Version: 0.21-fixeshead

comment:4 Changed 10 years ago by Shane Shrybman

Milestone: unknown0.22
Owner: changed from Isaac Richards to Shane Shrybman
Status: newaccepted

Changed 10 years ago by Shane Shrybman

comment:5 Changed 10 years ago by sphery

Resolution: fixed
Status: acceptedclosed

(In [21536]) Fix automatically mark as watched when prompts are enabled and setting bookmarks when using the embedded playback box.

Thanks to Shane S. for factoring out the commonalities and for fixing the bookmarks.

Fixes #5910. Fixes #4818.

Note: See TracTickets for help on using tickets.