Opened 16 years ago
Closed 15 years ago
#7521 closed patch (fixed)
[PATCH] AVFormatDecoder: Seeking Improvements
Reported by: | Owned by: | markk | |
---|---|---|---|
Priority: | minor | Milestone: | 0.23 |
Component: | MythTV - Video Playback | Version: | head |
Severity: | medium | Keywords: | |
Cc: | Ticket locked: | no |
Description
This patch addresses issues related to libav seeking. Here are a few key points related to the patch.
- We should only use exact seeks when doing frame-by-frame seeking. It is way to slow to perform exact seeks when doing FF/REW.
- Since we don't perform exact seeks for FF/REW it is important to set or clear the AVSEEK_FLAG_BACKWARD to avoid getting stuck in an infinite loop.
- Always flush the buffers when performing a seek.
- Please note that MPEG-TS seeking is currently slow so except for FF3X all other FF/REW speeds should be avoided. This is due to the fact that seeking in this container jumps back repeatedly causing the MythTV RingBuffer? protocol to rebuffer which is a high latency action. Apparently MPEG-TS seeking is being improved by the FFmpeg devs. Another option to improve performance is to use the 'file' protocol instead of the 'rbuffer' protocol.
Attachments (3)
Change History (6)
Changed 16 years ago by
Attachment: | avseek_fixes_rev1.diff added |
---|
Changed 16 years ago by
Attachment: | avseek_fixes_rev2.diff added |
---|
skip libavf seeking if the target frame is < 1 second away
comment:1 Changed 15 years ago by
Owner: | changed from Janne Grunau to markk |
---|---|
Status: | new → accepted |
comment:2 Changed 15 years ago by
Milestone: | unknown → 0.23 |
---|
comment:3 Changed 15 years ago by
Resolution: | → fixed |
---|---|
Status: | accepted → closed |
(In [23288]) Improved AVFormatDecoder seeking with patches from Taylor Ralph.
I've been testing for a few days and the improvement in navigating files without a markup (i.e. MythVideo?) is substantial.
I'd delayed due to an issue seen with certain test matroska files but I've now realised that this is a separate, existing seek problem with these files that manifests itself slightly differently following these changes.
Note: See
TracTickets for help on using
tickets.
avseek improvements