Modify

Opened 8 years ago

Closed 8 years ago

#7590 closed defect (fixed)

programinfo needs to init isVideo when loading from DB

Reported by: John Patrick Poet <jppoet@…> Owned by: danielk
Priority: minor Milestone: unknown
Component: MythTV - General Version: unknown
Severity: low Keywords:
Cc: Ticket locked: no

Description

ProgramInfo::ProgramInfo(const MSqlQuery &query, ...)

Does not initialize isVideo. This causes ProgramInfo::ToMap?() to randomly fill in starttime, endtime, startdate, etc., incorrectly.

Trivial patch attached.

Attachments (1)

programinfo-isVideo.patch (635 bytes) - added by John Patrick Poet <jppoet@…> 8 years ago.
Initialize isVideo in ProgramInfo? constructor from MSqlQuery

Download all attachments as: .zip

Change History (3)

Changed 8 years ago by John Patrick Poet <jppoet@…>

Initialize isVideo in ProgramInfo? constructor from MSqlQuery

comment:1 Changed 8 years ago by danielk

  • Owner changed from ijr to danielk
  • Status changed from new to assigned

comment:2 Changed 8 years ago by danielk

  • Resolution set to fixed
  • Status changed from assigned to closed

(In [22854]) Fixes #7590. Initialize all ProgramInfo? members in ctors.

This fixes the uninitialized variable John discovered, plus a couple other instances. It also reorders the clone function so as to make it easier to verify it in the future.

Add Comment

Modify Ticket

Action
as closed The owner will remain danielk.
The resolution will be deleted. Next status will be 'new'.
Author


E-mail address and user name can be saved in the Preferences.

 
Note: See TracTickets for help on using tickets.