Opened 9 years ago

Closed 9 years ago

#7590 closed defect (fixed)

programinfo needs to init isVideo when loading from DB

Reported by: John Patrick Poet <jppoet@…> Owned by: danielk
Priority: minor Milestone: unknown
Component: MythTV - General Version: unknown
Severity: low Keywords:
Cc: Ticket locked: no

Description

ProgramInfo::ProgramInfo(const MSqlQuery &query, ...)

Does not initialize isVideo. This causes ProgramInfo::ToMap?() to randomly fill in starttime, endtime, startdate, etc., incorrectly.

Trivial patch attached.

Attachments (1)

programinfo-isVideo.patch (635 bytes) - added by John Patrick Poet <jppoet@…> 9 years ago.
Initialize isVideo in ProgramInfo? constructor from MSqlQuery

Download all attachments as: .zip

Change History (3)

Changed 9 years ago by John Patrick Poet <jppoet@…>

Attachment: programinfo-isVideo.patch added

Initialize isVideo in ProgramInfo? constructor from MSqlQuery

comment:1 Changed 9 years ago by danielk

Owner: changed from Isaac Richards to danielk
Status: newassigned

comment:2 Changed 9 years ago by danielk

Resolution: fixed
Status: assignedclosed

(In [22854]) Fixes #7590. Initialize all ProgramInfo? members in ctors.

This fixes the uninitialized variable John discovered, plus a couple other instances. It also reorders the clone function so as to make it easier to verify it in the future.

Note: See TracTickets for help on using tickets.