Modify
Warning Please read the Ticket HowTo before creating or commenting on a ticket. Failure to do so may cause your ticket to be rejected or result in a slower response.

Opened 3 years ago

Closed 3 years ago

#9243 closed Patch - Bug Fix (Fixed)

[PATCH] multiple copies of static data in mythrender_opengl

Reported by: Lawrence Rust <lvr@…> Owned by: markk
Priority: minor Milestone: 0.24.1
Component: MythTV - Video Playback Version: Master Head
Severity: medium Keywords: Windows DLL opengl
Cc: Ticket locked: no

Description

Both libmythtv & libmythui include mythrender_opengl.cpp. This creates a problem on Win32 systems where each dll has its own static instance data. In this case static data for singleton objects is duplicated. The attached patch removes mythrender_opengl.cpp from libmythtv which already links against libmythui.

Attachments (1)

libmyth-ogl.diff (553 bytes) - added by Lawrence Rust <lvr@…> 3 years ago.
Remove multiple copies of mythrender_opengl.cpp

Download all attachments as: .zip

Change History (5)

Changed 3 years ago by Lawrence Rust <lvr@…>

Remove multiple copies of mythrender_opengl.cpp

comment:1 Changed 3 years ago by beirdo

  • Component changed from Ports - Windows to MythTV - Video Playback
  • Owner changed from nigel to markk
  • Status changed from new to assigned

comment:2 Changed 3 years ago by markk

(In [27279]) Remove some unnecessary includes from libmythtv.pro - with thanks to
Lawrence Rust.

Refs #9243

comment:3 Changed 3 years ago by markk

(In [27280]) Backport r27279 from trunk to release-0-24-fixes

Remove some unnecessary includes from libmythtv.pro - with thanks to
Lawrence Rust.

Refs #9243

comment:4 Changed 3 years ago by markk

  • Milestone changed from unknown to 0.24.1
  • Resolution set to Fixed
  • Status changed from assigned to closed

Add Comment

Modify Ticket

Action
as closed .
The resolution will be deleted. Next status will be 'new'.
Author


E-mail address and user name can be saved in the Preferences.

 
Note: See TracTickets for help on using tickets.