Opened 7 years ago

Closed 7 years ago

#9243 closed Patch - Bug Fix (Fixed)

[PATCH] multiple copies of static data in mythrender_opengl

Reported by: Lawrence Rust <lvr@…> Owned by: markk
Priority: minor Milestone: 0.24.1
Component: MythTV - Video Playback Version: Master Head
Severity: medium Keywords: Windows DLL opengl
Cc: Ticket locked: no

Description

Both libmythtv & libmythui include mythrender_opengl.cpp. This creates a problem on Win32 systems where each dll has its own static instance data. In this case static data for singleton objects is duplicated. The attached patch removes mythrender_opengl.cpp from libmythtv which already links against libmythui.

Attachments (1)

libmyth-ogl.diff (553 bytes) - added by Lawrence Rust <lvr@…> 7 years ago.
Remove multiple copies of mythrender_opengl.cpp

Download all attachments as: .zip

Change History (5)

Changed 7 years ago by Lawrence Rust <lvr@…>

Attachment: libmyth-ogl.diff added

Remove multiple copies of mythrender_opengl.cpp

comment:1 Changed 7 years ago by beirdo

Component: Ports - WindowsMythTV - Video Playback
Owner: changed from Nigel to markk
Status: newassigned

comment:2 Changed 7 years ago by markk

(In [27279]) Remove some unnecessary includes from libmythtv.pro - with thanks to Lawrence Rust.

Refs #9243

comment:3 Changed 7 years ago by markk

(In [27280]) Backport r27279 from trunk to release-0-24-fixes

Remove some unnecessary includes from libmythtv.pro - with thanks to Lawrence Rust.

Refs #9243

comment:4 Changed 7 years ago by markk

Milestone: unknown0.24.1
Resolution: Fixed
Status: assignedclosed
Note: See TracTickets for help on using tickets.