Opened 14 years ago

Closed 14 years ago

Last modified 13 years ago

#9667 closed Bug Report - General (fixed)

Cannot use mouse on group filter

Reported by: John Veness <John.Veness.mythtv@…> Owned by: stuartm
Priority: minor Milestone: 0.24.1
Component: MythTV - General Version: 0.24-fixes
Severity: medium Keywords:
Cc: Ticket locked: no

Description (last modified by Raymond Wagner)

On the rare occasions that I use my desktop PC to use Myth, I used to be able to use the mouse to navigate the menus and start playback of a recording. Now, it goes wrong at the stage where I pick the group filter. Specifically, I do the following:

1, Start mythfrontend
2, Use the mouse to click on TV (I use "classic" menu theme)
3, Use the mouse to click on Watch Recordings
4, The "Change Filter" window pops up (I have the setting "Always prompt for initial group filter" ticked)

At this point, I cannot use the mouse to click on a group to choose.

I used to be able to use the mouse to select a group in the Change Filter window (and then go on to pick a recording using the mouse) successfully in 0.22, so I suspect the problem started with the MythUI re-write.

Attachments (1)

version_info (661 bytes) - added by Raymond Wagner 14 years ago.

Download all attachments as: .zip

Change History (11)

comment:1 Changed 14 years ago by stuartm

Which theme are you using? Can you change to Terra and see if it still fails to work? I'm able to change the filter with a mouse just fine, I suspect this is a theme bug.

comment:2 Changed 14 years ago by John Veness <John.Veness.mythtv@…>

Ah yes, it does seem to depend on theme. For me, the problem occurs with Mythbuntu, MythCenter? and MythCenter?-wide themes, but does not occur with Terra.

Interestingly, what seems to be happening with Mythbuntu, MythCenter? and MythCenter?-wide themes is that the mouse clicks are going "through" the popup Change Filter window and onto the underlying list of recordings. So as I click, instead of changing the filter, I'm changing the selected recording underneath.

comment:3 Changed 14 years ago by stuartm

Ok thanks, it appears those themes must be failing to define correct areas for some aspect of the popup or list so the code cannot see that there are buttons there to activate.

comment:4 Changed 14 years ago by paulh

I believe this has been broken for a long time, I assumed it was a know problem but obviously not. It only affects non full screen screens which is why Terra works because all the popups are fullscreen.

comment:5 Changed 14 years ago by paulh

This patch fixes the problem for me (only lightly tested)

diff --git a/mythtv/libs/libmythui/mythuitype.cpp b/mythtv/libs/libmythui/mythuitype.cpp
index 50be483..a167741 100644
--- a/mythtv/libs/libmythui/mythuitype.cpp
+++ b/mythtv/libs/libmythui/mythuitype.cpp
@@ -1028,7 +1028,7 @@ void MythUIType::LoadNow(void)
  */
 bool MythUIType::ContainsPoint(const QPoint &point) const
 {
-    if (m_Area.contains(point - m_Area.topLeft()))
+    if (m_Area.contains(point))
         return true;
 
     return false;

comment:6 Changed 14 years ago by paulh

Milestone: unknown0.24.1
Resolution: Fixed
Status: newclosed
Version: Unspecified0.24-fixes

Fix mouse usage in popups, thanks to Paul for spotting the error. Fixes #9589

Changeset: afb8995fe52dd3a3f35ab6c256fd556cce68fd68

comment:7 Changed 14 years ago by Stuart Morgan

Resolution: Fixedfixed

Fix mouse usage in popups, thanks to Paul for spotting the error. Fixes #9667.

(cherry picked from commit afb8995fe52dd3a3f35ab6c256fd556cce68fd68)

Changeset: ae52b5874fbd8dd9e8dfc475c8e9c0a97c2eb12f

comment:8 Changed 14 years ago by Raymond Wagner

Description: modified (diff)

Changed 14 years ago by Raymond Wagner

Attachment: version_info added

comment:9 Changed 13 years ago by Mario Limonciello <Mario_Limonciello@…>

Owner: set to Mario Limonciello <Mario_Limonciello@…>

In bedaa209325e11632e0443bafb656b826ec01f39/packaging:

Error: Processor CommitTicketReference failed
GIT backend not available

comment:10 Changed 13 years ago by Kenni Lund [kenni a kelu dot dk]

Owner: changed from Mario Limonciello <Mario_Limonciello@…> to stuartm
Note: See TracTickets for help on using tickets.