Modify
Warning Please read the Ticket HowTo before creating or commenting on a ticket. Failure to do so may cause your ticket to be rejected or result in a slower response.

Opened 3 years ago

Closed 3 years ago

Last modified 2 years ago

#9667 closed Bug Report - General (fixed)

Cannot use mouse on group filter

Reported by: John Veness <John.Veness.mythtv@…> Owned by: stuartm
Priority: minor Milestone: 0.24.1
Component: MythTV - General Version: 0.24-fixes
Severity: medium Keywords:
Cc: Ticket locked: no

Description (last modified by wagnerrp)

On the rare occasions that I use my desktop PC to use Myth, I used to be able to use the mouse to navigate the menus and start playback of a recording. Now, it goes wrong at the stage where I pick the group filter. Specifically, I do the following:

1, Start mythfrontend
2, Use the mouse to click on TV (I use "classic" menu theme)
3, Use the mouse to click on Watch Recordings
4, The "Change Filter" window pops up (I have the setting "Always prompt for initial group filter" ticked)

At this point, I cannot use the mouse to click on a group to choose.

I used to be able to use the mouse to select a group in the Change Filter window (and then go on to pick a recording using the mouse) successfully in 0.22, so I suspect the problem started with the MythUI re-write.

Attachments (1)

version_info (661 bytes) - added by wagnerrp 3 years ago.

Download all attachments as: .zip

Change History (11)

comment:1 Changed 3 years ago by stuartm

Which theme are you using? Can you change to Terra and see if it still fails to work? I'm able to change the filter with a mouse just fine, I suspect this is a theme bug.

comment:2 Changed 3 years ago by John Veness <John.Veness.mythtv@…>

Ah yes, it does seem to depend on theme. For me, the problem occurs with Mythbuntu, MythCenter? and MythCenter?-wide themes, but does not occur with Terra.

Interestingly, what seems to be happening with Mythbuntu, MythCenter? and MythCenter?-wide themes is that the mouse clicks are going "through" the popup Change Filter window and onto the underlying list of recordings. So as I click, instead of changing the filter, I'm changing the selected recording underneath.

comment:3 Changed 3 years ago by stuartm

Ok thanks, it appears those themes must be failing to define correct areas for some aspect of the popup or list so the code cannot see that there are buttons there to activate.

comment:4 Changed 3 years ago by paulh

I believe this has been broken for a long time, I assumed it was a know problem but obviously not. It only affects non full screen screens which is why Terra works because all the popups are fullscreen.

comment:5 Changed 3 years ago by paulh

This patch fixes the problem for me (only lightly tested)

diff --git a/mythtv/libs/libmythui/mythuitype.cpp b/mythtv/libs/libmythui/mythuitype.cpp
index 50be483..a167741 100644
--- a/mythtv/libs/libmythui/mythuitype.cpp
+++ b/mythtv/libs/libmythui/mythuitype.cpp
@@ -1028,7 +1028,7 @@ void MythUIType::LoadNow(void)
  */
 bool MythUIType::ContainsPoint(const QPoint &point) const
 {
-    if (m_Area.contains(point - m_Area.topLeft()))
+    if (m_Area.contains(point))
         return true;
 
     return false;

comment:6 Changed 3 years ago by paulh

  • Milestone changed from unknown to 0.24.1
  • Resolution set to Fixed
  • Status changed from new to closed
  • Version changed from Unspecified to 0.24-fixes

Fix mouse usage in popups, thanks to Paul for spotting the error. Fixes #9589

Changeset: afb8995fe52dd3a3f35ab6c256fd556cce68fd68

comment:7 Changed 3 years ago by Stuart Morgan

  • Resolution changed from Fixed to fixed

Fix mouse usage in popups, thanks to Paul for spotting the error. Fixes #9667.

(cherry picked from commit afb8995fe52dd3a3f35ab6c256fd556cce68fd68)

Changeset: ae52b5874fbd8dd9e8dfc475c8e9c0a97c2eb12f

comment:8 Changed 3 years ago by wagnerrp

  • Description modified (diff)

Changed 3 years ago by wagnerrp

comment:9 Changed 2 years ago by Mario Limonciello <Mario_Limonciello@…>

  • Owner set to Mario Limonciello <Mario_Limonciello@…>

In bedaa209325e11632e0443bafb656b826ec01f39/packaging:

  • New upstream checkout (c2baf1b)
  • >>Upstream changes since last upload (00d86fd):
  • [c2baf1b] Fix initial pulseaudio volume.
  • [782b652] Fix lockTuner() and freeTuner() methods of MythBE. They relied on database access methods that had been removed prior to 0.23. (cherry picked from commit 5fd4a102989336841628b9764f2d7fe07162089f)
  • [db3cfd3] libmythui: Revert recent Compiz/fullscreen window fixes.
  • [4ce7cd8] Fix history handling of overridden find recordings.
  • [ccd73be] MythPlayer?: Fix decoder locking.
  • [ccc89dd] MythPlayer?: Only lock the eof check when run from the decoder thread.
  • [5e8685f] MythPlayer:: Remove some unnecessary decoder locking.
  • [8cc2e9a] libmythui: Fix fullscreen windowing with Compiz (and Gnome?)
  • [ee6aaa7] Video playback: Don't try and display the OSD when embedded. (cherry picked from commit 6ce20f63502997afe7bffa82ccc47825fcc6f143)
  • [1f532a5] MythUIFileBrowser: Fix a segfault if the 'back' button is missing.
  • [ae52b58] Fix mouse usage in popups, thanks to Paul for spotting the error. Fixes #9667. (cherry picked from commit afb8995fe52dd3a3f35ab6c256fd556cce68fd68)
  • [cf09840] Ignore the dividers on the Watch Recordings Change Group Filter popup. Fixes #9668. (cherry picked from commit 850dcfb0accb166f47c66e6ee940ca66ee0da148)
  • [71ff7fd] Mythmusic: Suppress some compiler warnings. (cherry picked from commit 6e71eda7fab37f8c657d357979ff051ccf324afc)
  • [223142c] Mythmusic: Fix fullscreen spectrum visualisation.
  • [a6decbc] windows: Support opengl, libfftw amd libvisual in mythplugins configure
  • [df16df9] OSX: Cross compilation fixes for mythmusic.
  • [f525415] OSX: Cross compilation fixes for libmythui
  • [e28fe98] OSX: Cross compilation fixes for libmythtv
  • [7f15abd] libmythfreemheg: Catch exception for unrecognised content
  • [f691e85] OpenGL: Avoid crashing hard if the OpenGL context is invalid.
  • [785ea1b] MythPlayer:: Add some missing null pointer checks for the decoder.
  • [40fc454] Change ENVCAN parser to use &deg; rather than 260
  • [13be9c2] Merge branch 'fixes/0.24' of github.com:MythTV/mythtv into fixes/0.24
  • [9d533f3] Do not attempt to increase ALSA buffer size if it's already set to the maximum the hardware can handle
  • [b41e218] Change ALSA buffer size and period size

comment:10 Changed 2 years ago by kenni

  • Owner changed from Mario Limonciello <Mario_Limonciello@…> to stuartm

Add Comment

Modify Ticket

Action
as closed .
The resolution will be deleted. Next status will be 'new'.
Author


E-mail address and user name can be saved in the Preferences.

 
Note: See TracTickets for help on using tickets.