Opened 14 years ago
Closed 14 years ago
#9674 closed Bug Report - General (fixed)
MythUIEditBar broken
| Reported by: | Owned by: | stuartm | |
|---|---|---|---|
| Priority: | minor | Milestone: | 0.25 |
| Component: | MythTV - User Interface Library | Version: | Master Head |
| Severity: | medium | Keywords: | |
| Cc: | Ticket locked: | no |
Description (last modified by )
Some fairly recent change in trunk has broken the MythUIEditBar when editing a recording. It appears that the "keep" and "cut" shapes are not being cropped to the correct width. My best guess is that this started with [e949f5fe9d9dd267bdeedd1a8de4588c43a1d8ce].
This happens with all themes I tried (Blue Abstract, MythBuntu?, and Terra), and with Slim and VDPAU Normal playback profiles.
Same behavior when unapplying my patches and using a clean build.
Attachments (3)
Change History (8)
comment:1 Changed 14 years ago by
Changed 14 years ago by
| Attachment: | 9674.patch added |
|---|
Changed 14 years ago by
| Attachment: | 9674.2.patch added |
|---|
comment:3 Changed 14 years ago by
Uploaded a slightly cleaner / more efficient version of the patch.
To address Mark's question, the problem should show up on the edit bar for any theme in which the "editbar" section of osd.xml has "keep" defined as a shape (as in default-wide or Terra), rather than as an imagetype (as in MythCenter?-wide). The width of every "keep" bar becomes the full length of the recording, instead of being cropped to the correct duration, effectively hiding all "cut" bars except for the first one. There are other incorrect visual artifacts, but this is the most glaring one. Also, it's not surprising that the problem doesn't show up widely, since MythUIEditBar and MythUIProgressBar are the only internal components that use cropping on shapes.
Changed 14 years ago by
| Attachment: | version_info added |
|---|
comment:5 Changed 14 years ago by
| Milestone: | unknown → 0.25 |
|---|---|
| Resolution: | → fixed |
| Status: | new → closed |
libmythui: Fix rendering of MythUIEditBar
Some cropping adjustments were lost when the painter classes where re-factored and MythUIShape rendering was moved into the painters.
Closes #9674.
Signed-off-by: Mark Kendall <mkendall@…>
Changeset: 95a9b5df134eca166a111512c3d53d8cc0e20e62
I've just tested on two boxes with the latest master on both and I can't see any problems. If there were issues with the latest painter changes, they would be showing up elsewhere and not just in the edit bar. Are you sure you're up to date? - there was a fix that went in for the shape cache.