livetv fails for analog on hvr 2250 + segfault

[Brent Elmer <webe3vt@…>]

I have a hauppauge 2250 tuner. The tuner works fine in mythfrontend when using the digital side. The analog side has worked but it is very rare. The analog side always works in mplayer or xbmc with the myth pvr plugin. In mythfrontend when I try to watch analog live tv it just times out trying. The latest fix version has also segfaulted several times when trying to watch analog livetv.

[Brent Elmer <webe3vt@…>]

frontend log segfault

[Brent Elmer <webe3vt@…>]

with debug level

[Brent Elmer <webe3vt@…>]

gdb backtrace when segfault

[Brent Elmer <webe3vt@…>]

I am running on Debian testing/wheezy. I get mythtv from deb-multimedia. The mythtv version is 0.26.0+fixes20130206-dmo1

[Jonatan Lindblad <jlindblad@…>]

In 6e0f69dca6a554f4baf0fe8f9226458d36c459c7/mythtv:

MythUI: Fix use after free in MythUIEditBar

The call to ReleaseImages?() in MythUIEditBar's dtor caused a free memory read
since SetRedraw?() accesses its parent whose dtor has already been called.

Calling ReleaseImages?() from MythUIEditBar's dtor also isn't necessary since the
images in m_images are children of MythUIEditBar and are automatically deleted
by Qt.

Fixes #11458, Refs #11402

[Jonatan Lindblad <jlindblad@…>]

In c0419cd1759f299a4232c12cf62dbea8b30180f2/mythtv:

MythUI: Fix use after free in MythUIEditBar

The call to ReleaseImages?() in MythUIEditBar's dtor caused a free memory read
since SetRedraw?() accesses its parent whose dtor has already been called.

Calling ReleaseImages?() from MythUIEditBar's dtor also isn't necessary since the
images in m_images are children of MythUIEditBar and are automatically deleted
by Qt.

Fixes #11458, Refs #11402
(cherry picked from commit 6e0f69dca6a554f4baf0fe8f9226458d36c459c7)

[webe3vt@…]

Analog still hardly every works from mythfrontend even though it always works from mplayer and xbmc with mythplugin. The segfault did go away with the fix though.

I have stepped through with a debugger. It seems that when switching to an analog channel, something gives up too soon and fails before the channel is changed. Switching to a digital channel always works. Occasionally switching to an analog channel does work. I have yet to be able to get to the code that is giving up and failing when switching to an analog channel.

[Jay Jaeger <cube1@…>]

This might be related to one or more of a couple of tickets I reported recently, #11960 and #11961 ?

[webe3vt@…]

I have run the code in the debugger and come up with a small patch to make mythfrontend play live tv and change channels on the analog and composite inputs. Basically, in the file libs/libmythtv/mythplayer.cpp in the function OpenFile? for my older hardware and the Hauppauge 2250 card, the timeouts need to be a little higher. I changed int timeout = (retries + 1) * 500; to int timeout = (retries + 1) * 600;

and

if (peekTimer.elapsed() > 1000

bigTimer.elapsed() > timeout)

to

if (peekTimer.elapsed() > 1500

bigTimer.elapsed() > timeout)

Both of the changes seemed to be necessary to make it work. Once I made the changes, livetv worked and changing channels worked for both analog and digital. This small change shouldn't affect anyone else.

[webe3vt@…]

Any idea when this patch will be applied?

[John Poet <jpoet@…>]

In b387dbeb6e8edb42edf42b3173db1d9b31e9c8e5/mythtv:

Extend the time-outs in mythplayer to allow the analog side of the hvr-2250

to work.

Patch by webe3vt@…

Fixes #11402

[Jean-Yves Avenard <jyavenard@…>]

In 6a39d522936046d038585bdb1ca847f5ff0f4c04/mythtv:

Extend the time-outs in mythplayer to allow the analog side of the hvr-2250

to work.

Patch by webe3vt@…

Fixes #11402

(cherry picked from commit b387dbeb6e8edb42edf42b3173db1d9b31e9c8e5)